Commit Graph

679 Commits

Author SHA1 Message Date
SGavrl
5b602259c6 test: gate flex text alignment geometry 2026-07-23 15:58:37 +00:00
SGavrl
bd9c161f55 render: separate text and item alignment 2026-07-23 15:58:37 +00:00
SGavrl
49541792ee test: gate background shorthand reset 2026-07-23 15:43:24 +00:00
SGavrl
201c5f6c6f render: reset omitted background layers 2026-07-23 15:43:24 +00:00
SGavrl
ea3ff7ca4f test: gate replaced wrapper geometry 2026-07-23 15:35:02 +00:00
SGavrl
f83bdd36cf render: contain responsive replaced wrappers 2026-07-23 15:34:57 +00:00
SGavrl
cedec298d5 test: require float clear fill available 2026-07-23 15:13:52 +00:00
SGavrl
6c77eb2383 render: preserve block fill beside floats 2026-07-23 15:13:40 +00:00
SGavrl
bbdb779de9 test: gate opposing float geometry 2026-07-23 15:04:03 +00:00
SGavrl
85613b741d render: place opposing floats in one band 2026-07-23 15:03:50 +00:00
SGavrl
c7438370db test: gate replaced grid geometry 2026-07-23 14:48:36 +00:00
SGavrl
9471591c6c render: preserve responsive image grid geometry 2026-07-23 14:48:27 +00:00
SGavrl
7ddf52eb27 test: gate font shorthand geometry 2026-07-23 14:25:14 +00:00
SGavrl
da5cc2cc2a render: honor font shorthand 2026-07-23 14:25:09 +00:00
SGavrl
944db4b104 test: gate float flow geometry 2026-07-23 14:10:02 +00:00
SGavrl
735375ee33 render: preserve float flow bands 2026-07-23 14:09:57 +00:00
SGavrl
1f85dfce6b test: gate flex item geometry 2026-07-23 13:34:19 +00:00
SGavrl
64b628404b render: ignore non-items in flex layout 2026-07-23 13:34:09 +00:00
SGavrl
f8aac61c0b test: gate contextual CSS math geometry 2026-07-23 12:53:23 +00:00
SGavrl
29628df548 render: resolve contextual CSS math 2026-07-23 12:53:11 +00:00
SGavrl
acc4422f48 test: gate responsive grid geometry 2026-07-23 12:42:08 +00:00
SGavrl
df9359ec87 render: honor responsive grid track syntax 2026-07-23 12:41:56 +00:00
SGavrl
1e71053169 test: report structural geometry deltas 2026-07-23 12:31:05 +00:00
SGavrl
ca31d39070 test: gate relative box edge geometry 2026-07-23 12:30:56 +00:00
SGavrl
b13a1e5e71 render: resolve relative box edge lengths 2026-07-23 12:30:44 +00:00
SGavrl
7d74c15f31 test: gate block auto margin geometry 2026-07-23 12:19:39 +00:00
SGavrl
b39ada2fc0 render: resolve block auto margins 2026-07-23 12:19:29 +00:00
SGavrl
2f559aeccf test: gate modern containing-block coordinates
Add exact Chromium coordinate checks for effect, containment, will-change,
and content-visibility triggers, with container-type as a pinned negative
control.
2026-07-23 12:03:05 +00:00
SGavrl
7827a6a788 render: honor modern containing-block triggers
Track transform, filter, backdrop-filter, perspective, containment,
will-change, and content-visibility triggers independently. Use the combined
state for absolute and fixed containing-block ancestry.
2026-07-23 12:02:55 +00:00
SGavrl
b44e59ef71 test: gate transformed positioning coordinates
Add an exact Chromium fixture for absolute and fixed descendants of
transformed boxes, an unsupported identity transform, and the viewport-fixed
control case.
2026-07-23 11:47:12 +00:00
SGavrl
bbeceb97ad render: honor transform containing blocks
Track every non-none transform as a containing-block trigger, including
unsupported visual transforms. Keep separate nearest-ancestor maps so
positioned boxes capture absolute descendants while only transforms capture
fixed descendants.
2026-07-23 11:47:00 +00:00
SGavrl
1526d02200 test: assert absolute placement coordinates
Add a portable containing-block fixture covering start, end, percentage, and
fixed insets. Extend solid-color component checks to validate coordinates as
well as dimensions.
2026-07-23 11:34:31 +00:00
SGavrl
6ea1739121 render: position inset boxes against CSS containers
Reparent inset-positioned absolute boxes to the nearest non-static ancestor
and fixed boxes to the initial containing block. Keep auto-axis boxes on the
existing static-position path, distinguish fixed from absolute, and blockify
positioned inline boxes and floats.
2026-07-23 11:34:23 +00:00
SGavrl
d36809058f test: gate modern hydration contracts
Add portable checks for live attribute maps, parser script moves, element
scrolling, and streamed codec transforms. Capture Chromium references through
Playwright's pinned browser and record the exact version and lifecycle.
2026-07-23 11:00:11 +00:00
SGavrl
5de5d07c24 render: support streamed framework hydration
Make attribute maps live, preserve parser script execution state, and expose
element scrolling used by React commit callbacks. Connect fallback web streams
so React Router and Remix hydration payloads flow through codec transforms.
2026-07-23 10:59:51 +00:00
SGavrl
571c419e51 test: add deterministic render parity checks 2026-07-23 10:07:04 +00:00
SGavrl
4979606a2f render: respect CSS box sizing 2026-07-23 10:06:55 +00:00
SGavrl
a11f87d0c9 test: fail render repros on missing screenshots 2026-07-22 13:00:08 +00:00
SGavrl
3d7a8e2582 render: honor important cascade priority 2026-07-22 12:59:55 +00:00
SGavrl
b7c3d086bf docs: render handover, fix plan, and repro fixtures
Adds docs/render with a handover covering what shipped on this branch,
the verification methodology, build gotchas, and the prioritized list of
remaining work, alongside the phase plan and the index of the Gecko
layout study that informed it.

Adds render-repros: one HTML fixture per bug fixed here (absolute fills,
mixed inline+block layout, carousel clipping, z-index order, clear,
tables, image density and alt fallback) plus run.sh to render them all
in obscura and Chromium for side-by-side checking. Run before and after
any layout or paint change.
2026-07-22 12:32:25 +00:00
SGavrl
22f33e4dec render: z-index paint layers and clear ending float zones
Paint order was pure tree order, so a dropdown/overlay declared before a
later sibling lost to it and a z:-1 decorative backdrop covered its own
content. A positioned element with a non-zero z-index now lifts its
whole subtree into a separate paint layer: negative layers under the
normal flow, positive above it, each sorted ascending with tree order
preserved within equal z. Nested z roots paint inside their ancestor
root's subtree in tree order, the pragmatic core of CSS stacking
contexts.

clear (left/right/both, previously unparsed) now ends the float zone,
so a clearfix element drops below the float at full width instead of
joining the flow column beside it.

Repro-verified: an earlier z:10 overlay paints over a later sibling, a
later z:-1 backdrop paints under earlier content, and the clear repro
matches Chromium within 3px on every measure. Spot set unchanged or
slightly improved; obstacle course 33/33.
2026-07-16 13:10:28 +00:00
SGavrl
953292563d render: table vertical-align and specified column/row sizing
Cells now vertical-align the way tables actually do: middle by default
(the effective UA behavior), with author top/middle/bottom parsed and
applied to whichever shape the cell took: main-axis alignment on the
flex-column stand-in, line alignment on a promoted inline context, or a
pinned-origin offset for the pure-text leaf path where the shaped text
height is known at finalize.

Specified column widths finally apply. <col>/<colgroup> widths (style
or attribute, with span) and colspan-1 cell widths are recorded per
column at build time and pinned inside the column-balancing pass: px
directly, percent against the table's content width, with each column's
content min-content still flooring it. The cell's own width is
neutralized once it has fed the column, so the cell box fills its grid
area instead of shrinking to a fraction of its own already-sized track
(a width:50% cell previously ended up at 25 percent). Unspecified
columns keep content sizing but stretch to fill a definite table width
instead of leaving a dead strip of table background. Row and cell
heights act as row minimums.

Verified against Chromium on a 5-case repro (column from cell width,
row backgrounds, vertical alignment, col element width, percent cell in
a fixed table): all match. Wikipedia and the prose spot set unchanged;
obstacle course 33/33.
2026-07-16 12:47:47 +00:00
SGavrl
1d96c316ca render: clip image rasters to their visible bound, browser-like alt fallback
paint_image clipped an object-fit:cover overflow to the element box but
ignored the ancestor overflow:hidden clip entirely, so a partially
visible image (a half-scrolled carousel slide, a hero cropped by its
section) painted its full raster past the viewport edge. Pass the
already clip-intersected visible rect down and mask against it whenever
the destination exceeds it on any side.

Broken images now fall back the way browsers do: a non-empty alt renders
as text in place of the image with no placeholder box, alt="" renders
nothing (declared decorative), and only a missing alt keeps the neutral
grey placeholder.

Verified with a repro covering the half-clipped cover slide and all
three alt variants; no movement on the image-heavy spot set; obstacle
course 33/33.
2026-07-16 12:23:17 +00:00
SGavrl
c29c64fc57 render: scale image intrinsic size by the selected srcset density
The srcset picker already normalized every candidate to a pixel density
(x descriptor, or w / source-size) to choose one, then threw the density
away, so layout sized the image from the file's raw pixels. Every 2x
responsive asset occupied twice its design size.

Return the picked candidate's density alongside its URL (img srcset,
data-srcset, and picture source paths alike) and divide the fetched
intrinsic dimensions by it, so layout sees CSS px.

Verified: srcset "x.png 2x" of a 648px file lays out at 324 CSS px and
"648w" with sizes=300px at 300, while a bare src stays at raw size; no
regressions on the image-heavy spot set (a bbc delta traced to homepage
content drift against a days-old baseline, 8.0 vs 7.8 percent when
recaptured same-time); obstacle course 33/33.
2026-07-16 12:08:19 +00:00
SGavrl
35cbbff9b2 render: real block layout for mixed content, owner-space overflow clips
Two structural fixes to the layout and paint model.

Mixed inline+block content: a block holding both was promoted wholesale
to a flex-row-wrap container to approximate the inline formatting
context. That collapsed contentless block children to width 0 (a
position:relative hero wrapper whose only child is an absolute fill
image vanished with it) and let text share lines with sibling blocks.
Now the parent stays a real block, block-level children stay direct
children (auto width fills the containing block), and each maximal run
of consecutive inline-level siblings becomes one anonymous block-level
box carrying the IFC. A run of pure text and foldable inline wrappers
collapses to a single shaped cosmic-text leaf (one taffy node per run
instead of one per word); runs with atomic inline boxes fall back to a
flex-wrap wrapper. Absolutely positioned children neither join nor
break runs and no longer count as inline content, so their containing
block keeps its real used width and taffy resolves width:100%/inset:0
fills against it.

Overflow clips: an inherited overflow:hidden clip was shifted by the
painted node's own accumulated translate, so a carousel track's
translateX dragged the viewport's clip along with every slide and all
slides stayed visible stacked. Clips are now stored in the clip owner's
coordinate space (owner translate baked in at resolve time) and no
longer move with descendants, for boxes, per-word text, and shaped
inline items alike. The same walk records per-node accumulated
translates once, replacing the per-painted-node ancestor walks. Also
parse translate3d (Swiper-style carousels position their track
exclusively through it) and make transform:none reset a lower-priority
transform.

Verified: abs-fill repros that rendered 0x0 now fill across
block/flex/grid parents; carousel repro shows exactly one slide;
danluu.com mismatch vs Chromium 13.0 to 5.7 percent; no regressions
across the prose and framework spot sets; obstacle course 33/33; 36
percent faster on a layout-bound synthetic page with neutral real-page
memory.
2026-07-16 11:58:10 +00:00
SGavrl
8fa387faed render: respect stylesheet gating (disabled/media) and follow @import
Skip <link rel=stylesheet> sheets that are disabled or gated to
print/dark, and resolve @import chains inside fetched sheets so the
imported CSS reaches the cascade.

- disabled links (JS-toggled alternate themes) no longer paint pages
  dark under a light Chromium
- media="(prefers-color-scheme: dark)" link sheets are skipped
- @import url(...) is fetched recursively; Sphinx docs pull their layout
  from basic.css via classic.css and it was being dropped

Pixel fidelity vs headless Chromium: docs.python 95.5 to 10.2 percent,
web.dev 91.1 to 10.5, developer.chrome 88.0 to 18.9. No regressions on
the good-site set; obstacle course still 33/33.
2026-07-16 11:56:28 +00:00
SGavrl
ea486a8900 render: blockify grid items so inline children lay out correctly
A direct child of a grid container is blockified per CSS Display 3, so an
inline <a>/<time>/<span> becomes its own block-level grid item instead of
being flattened into loose words in the container (which shattered grid
lists like jvns.ca's .article-list of alternating <time>/<a> into one word
per cell). Grid only, not flex, since flex-column is also our block
stand-in for <td>.
2026-07-11 22:17:33 +00:00
SGavrl
e559dc2b64 render: resolve protocol-relative image URLs
An <img src="//host/path"> (ubiquitous on Wikipedia and CDN-hosted media)
now inherits the document scheme, defaulting to https for non-network bases
so a file:// page does not turn it into file://host. Previously url::join
against a file base produced an unfetchable URL.
2026-07-11 22:01:14 +00:00
SGavrl
281a22e247 render: match Chrome font metrics with Liberation Sans/Serif/Mono
Chrome's default sans-serif on this class of host is Liberation Sans, not
DejaVu (measured: sans-serif == Arial == Helvetica == Liberation width,
DejaVu ~12% wider). Forcing DejaVu drifted all text wider and shifted
every line. Bundle Liberation Sans/Serif/Mono (DejaVu kept as glyph
fallback), default to Liberation Sans, and resolve font-family to the
right generic (monospace/code -> Mono, serif -> Serif, else -> Sans).
A controlled text page drops from ~15-20% to 3.5% pixel mismatch and
every line lands within 1px of Chrome.
2026-07-11 21:49:33 +00:00
SGavrl
23594b1f96 render: percentage padding, box-shadow, external-sprite svg, gradient text
percentage padding/margin: top/bottom percentages resolve against the
containing-block width (the responsive aspect-ratio-box trick, e.g.
padding-top:56.25%), resolved to px in the top-down layout pass so card
media boxes reserve space instead of collapsing.
box-shadow: parse and paint an outset shadow (rounded, offset, spread,
soft-edge approximation) so cards/buttons/menus have depth.
external-sprite svg: resolve <use href="url#id"> to an external sprite
file, inject the referenced symbol so inline-svg icon systems rasterize.
background-clip:text: paint transparent-with-gradient text (the common
gradient hero/button label) instead of leaving it invisible.
2026-07-11 21:02:57 +00:00