Files
obscura/crates/obscura-js/src/runtime.rs
T
SGavrl 08c1f0d721 fix(cdp): fire onChange for React/Vue controlled inputs (#353)
Typing over CDP into a React controlled input never fired onChange, so
the value never reached component state (issue #324). Two root causes,
both needed:

1. Value tracker. React/Preact/Vue install a value tracker by redefining
   `value` on the element instance to record the last value they wrote.
   obscura's CDP typing assigned `el.value = ...` directly, which runs
   that wrapper and keeps the tracker in sync, so React saw no change on
   the input event. Synthetic value/backspace writes now go through a new
   __obscura_setFieldValue helper that writes via the element's prototype
   setter, bypassing the tracker. The tracker stays stale, so the input
   event reads as a real edit.

2. Event handler feature detection. React decides whether to use the
   modern `input` event via `("oninput" in document)`. obscura exposed the
   GlobalEventHandlers on* attributes only on window, so that check failed
   and React fell back to a legacy change-detection path that ignores
   input events. The on* attributes are now also present on Document and
   Element, matching the HTML spec (GlobalEventHandlers is mixed into
   Window, Document, and HTMLElement).

Verified end to end over CDP against the real React 18 UMD build: typing
into controlled inputs updates state, the component re-renders, and a
submit handler reads the captured values.

Closes #324.
2026-07-03 14:10:03 +02:00

2601 lines
105 KiB
Rust

use std::cell::RefCell;
use std::collections::HashMap;
use std::rc::Rc;
use deno_core::{JsRuntime, RuntimeOptions};
use obscura_dom::DomTree;
/// Re-exported so other crates (obscura-browser, obscura-cdp) can name the V8
/// isolate handle without taking a direct dependency on deno_core.
pub use deno_core::v8::IsolateHandle;
use crate::module_loader::ObscuraModuleLoader;
use crate::ops::{build_extension, ObscuraState, StoredNetworkResponseBody};
static SNAPSHOT: &[u8] = include_bytes!(env!("OBSCURA_SNAPSHOT_PATH"));
#[derive(Debug, Clone)]
pub struct RemoteObjectInfo {
pub js_type: String,
pub subtype: Option<String>,
pub class_name: String,
pub description: String,
pub object_id: Option<String>,
pub value: Option<serde_json::Value>,
}
pub struct ObscuraJsRuntime {
runtime: JsRuntime,
state: Rc<RefCell<ObscuraState>>,
object_store: HashMap<String, String>,
object_counter: u64,
/// Thread-safe handle to this runtime's V8 isolate, captured at
/// construction. Lets a watchdog be armed from `&self` (the CDP dispatcher
/// only holds `&Page` on the hot path) and is stable for the isolate's life.
isolate_handle: IsolateHandle,
}
/// Handle to an armed V8 execution watchdog (see [`ObscuraJsRuntime::arm_watchdog`]).
/// Holds the cancel channel and the watchdog thread; pass it back to
/// `disarm_watchdog` to stop the watchdog and learn whether it fired.
pub struct WatchdogToken {
pair: std::sync::Arc<(std::sync::Mutex<bool>, std::sync::Condvar)>,
join: Option<std::thread::JoinHandle<()>>,
fired: std::sync::Arc<std::sync::atomic::AtomicBool>,
}
/// Arm a V8 termination watchdog directly from an isolate handle, with no
/// runtime borrow. The CDP dispatcher uses this to bound every command so a
/// hung page cannot hold the process-wide V8 lock forever. Pair with
/// [`WatchdogToken::stop`]; if `stop` returns true, clear the termination flag
/// via [`ObscuraJsRuntime::cancel_termination`] before reusing the isolate.
pub fn spawn_watchdog(handle: IsolateHandle, budget: std::time::Duration) -> WatchdogToken {
let pair = std::sync::Arc::new((std::sync::Mutex::new(false), std::sync::Condvar::new()));
let fired = std::sync::Arc::new(std::sync::atomic::AtomicBool::new(false));
let pair_c = pair.clone();
let fired_c = fired.clone();
let join = std::thread::spawn(move || {
let (lock, cvar) = &*pair_c;
let mut cancelled = lock.lock().unwrap();
let deadline = std::time::Instant::now() + budget;
loop {
// Check first: stop() may have set this (and notified into the void)
// before this thread even started, which happens constantly for fast
// CDP commands where stop() is called right after spawn. Without this
// top check the lost notify means we wait the full budget before
// noticing, and stop()'s join() blocks for that whole time.
if *cancelled {
return;
}
let remaining = deadline.saturating_duration_since(std::time::Instant::now());
if remaining.is_zero() {
fired_c.store(true, std::sync::atomic::Ordering::SeqCst);
handle.terminate_execution();
return;
}
let (guard, _) = cvar.wait_timeout(cancelled, remaining).unwrap();
cancelled = guard;
if *cancelled {
return;
}
}
});
WatchdogToken { pair, join: Some(join), fired }
}
impl WatchdogToken {
/// Stop the watchdog. Returns true if it had already fired (terminated the
/// isolate). The caller must then clear the termination flag via
/// [`ObscuraJsRuntime::cancel_termination`] before the next eval.
pub fn stop(mut self) -> bool {
{
let (lock, cvar) = &*self.pair;
*lock.lock().unwrap() = true;
cvar.notify_one();
}
if let Some(j) = self.join.take() {
let _ = j.join();
}
self.fired.load(std::sync::atomic::Ordering::SeqCst)
}
}
impl ObscuraJsRuntime {
pub fn new() -> Self {
Self::with_base_url("about:blank")
}
pub fn with_base_url(base_url: &str) -> Self {
Self::with_base_url_and_proxy(base_url, None)
}
/// Construct a runtime whose ES-module loader routes dynamic imports
/// through `proxy_url` (#139). `None` is equivalent to `with_base_url`
/// (direct connection).
pub fn with_base_url_and_proxy(base_url: &str, proxy_url: Option<String>) -> Self {
let state = Rc::new(RefCell::new(ObscuraState::new()));
let state_clone = state.clone();
let module_loader = Rc::new(ObscuraModuleLoader::with_proxy(base_url, proxy_url));
let mut runtime = JsRuntime::new(RuntimeOptions {
extensions: vec![build_extension()],
module_loader: Some(module_loader),
startup_snapshot: Some(SNAPSHOT),
..Default::default()
});
runtime.op_state().borrow_mut().put(state_clone);
runtime
.execute_script(
"<obscura:init>",
"globalThis.__obscura_objects = {}; globalThis.__obscura_oid = 0;".to_string(),
)
.expect("init should not fail");
let isolate_handle = runtime.v8_isolate().thread_safe_handle();
ObscuraJsRuntime {
runtime,
state,
object_store: HashMap::new(),
object_counter: 0,
isolate_handle,
}
}
pub fn set_cookie_jar(&self, jar: std::sync::Arc<obscura_net::CookieJar>) {
self.state.borrow_mut().cookie_jar = Some(jar);
}
pub fn set_http_client(&self, client: std::sync::Arc<obscura_net::ObscuraHttpClient>) {
self.state.borrow_mut().http_client = Some(client);
}
/// Install the stealth (wreq) HTTP client so scripted fetch()/XHR is routed
/// through it in stealth mode (see op_fetch_url / stealth_fetch_all).
#[cfg(feature = "stealth")]
pub fn set_stealth_client(&self, client: std::sync::Arc<obscura_net::StealthHttpClient>) {
self.state.borrow_mut().stealth_client = Some(client);
}
pub fn set_dom(&self, dom: DomTree) {
self.state.borrow_mut().dom = Some(dom);
}
pub fn set_url(&self, url: &str) {
self.state.borrow_mut().url = url.to_string();
}
/// Set the document's character encoding (WHATWG canonical name). Backs
/// `document.characterSet` and the `<a>`/`<area>` URL query encoding
/// override for legacy-charset documents.
pub fn set_encoding(&self, encoding: &str) {
self.state.borrow_mut().encoding = encoding.to_string();
}
pub fn set_title(&self, title: &str) {
self.state.borrow_mut().title = title.to_string();
}
pub fn set_blocked_urls(&self, patterns: Vec<String>) {
self.state.borrow_mut().blocked_urls = patterns;
}
pub fn take_pending_navigation(&self) -> Option<(String, String, String)> {
self.state.borrow_mut().pending_navigation.take()
}
pub fn take_pending_binding_calls(&self) -> Vec<(String, String)> {
std::mem::take(&mut self.state.borrow_mut().pending_binding_calls)
}
pub fn get_network_response_body(&self, request_id: &str) -> Option<StoredNetworkResponseBody> {
self.state.borrow().network_response_bodies.get(request_id).cloned()
}
pub fn clear_network_response_bodies(&self) {
let mut state = self.state.borrow_mut();
state.network_response_bodies.clear();
state.network_response_body_order.clear();
}
/// Wire up the interception channel without enabling interception.
/// Use set_intercept_enabled separately. The two were entangled before
/// and every navigation auto-enabled interception, which made
/// `fetch()` from page JS hang forever waiting for a CDP client to
/// answer Fetch.requestPaused events that the client never asked for.
pub fn set_intercept_tx(&self, tx: tokio::sync::mpsc::UnboundedSender<crate::ops::InterceptedRequest>) {
let mut state = self.state.borrow_mut();
state.intercept_tx = Some(tx);
}
pub fn set_intercept_enabled(&self, enabled: bool) {
let mut state = self.state.borrow_mut();
state.intercept_enabled = enabled;
}
pub fn set_user_agent(&mut self, ua: &str) {
let escaped = ua.replace('\\', "\\\\").replace('\'', "\\'");
let _ = self.runtime.execute_script(
"<set-ua>",
format!("globalThis.__obscura_ua = '{}';", escaped),
);
}
pub fn set_platform(&mut self, platform: &str, ua_platform: &str, ua_platform_version: &str) {
let p = platform.replace('\'', "\\'");
let uap = ua_platform.replace('\'', "\\'");
let uapv = ua_platform_version.replace('\'', "\\'");
let _ = self.runtime.execute_script(
"<set-platform>",
format!(
"globalThis.__obscura_platform='{}';globalThis.__obscura_ua_platform='{}';globalThis.__obscura_ua_platform_version='{}';",
p, uap, uapv
),
);
}
pub fn set_stealth(&mut self, enabled: bool) {
let _ = self.runtime.execute_script(
"<set-stealth>",
format!("globalThis.__obscura_stealth = {};", enabled),
);
}
/// Run __obscura_init() after all per-page properties (UA, platform, stealth, etc.)
/// have been set. Must be called once per page setup, after all set_* methods.
pub fn run_page_init(&mut self) {
let _ = self.runtime.execute_script(
"<obscura:page-init>",
"globalThis.__obscura_init();".to_string(),
);
}
/// Override the coordinates the navigator.geolocation shim reports. The
/// values are injected as numeric globals the bootstrap reads; when unset it
/// keeps the built-in default. Callers validate the range before calling.
pub fn set_geolocation(&mut self, latitude: f64, longitude: f64) {
let _ = self.runtime.execute_script(
"<set-geo>",
format!(
"globalThis.__obscura_geo_lat={};globalThis.__obscura_geo_lon={};",
latitude, longitude
),
);
}
pub fn evaluate(&mut self, expression: &str) -> Result<serde_json::Value, String> {
let wrapped = Self::wrap_expression(expression);
let result = self
.runtime
.execute_script("<eval>", wrapped)
.map_err(|e| format!("JS error: {}", e))?;
self.v8_to_json(result)
}
pub async fn evaluate_for_cdp(
&mut self,
expression: &str,
return_by_value: bool,
await_promise: bool,
) -> Result<RemoteObjectInfo, String> {
if !await_promise && return_by_value {
let val = self.evaluate(expression)?;
return Ok(Self::info_from_json(&val));
}
self.object_counter += 1;
let oid = self.make_oid(self.object_counter);
// Same trailing-semicolon trim as wrap_expression — Playwright's
// utility-script eval ends with `})();`, and `({expr})` would
// otherwise become `(...;)` which is a parse-time SyntaxError.
let cleaned_expr = expression
.trim()
.trim_end_matches(|c: char| c == ';' || c.is_whitespace());
// Puppeteer / Playwright bundles end with a `//# sourceURL=...`
// line comment. If we put `{expr})` on a single line the comment
// swallows the closing paren and our wrapper breaks. A newline
// before the `)` terminates any trailing line comment so the
// parens close on their own line.
let done_counter = self.object_counter;
let meta_code = if await_promise {
format!(
"(async function() {{\n\
try {{\n\
var __result = await (\n{expr}\n);\n\
globalThis.__obscura_objects['{oid}'] = __result;\n\
globalThis.__obscura_await_meta = {meta_fn};\n\
globalThis.__obscura_await_rejected = false;\n\
}} catch(e) {{\n\
globalThis.__obscura_objects['{oid}'] = e;\n\
globalThis.__obscura_await_meta = {err_meta_fn};\n\
globalThis.__obscura_await_rejected = true;\n\
}}\n\
globalThis.__obscura_done_{done_counter} = true;\n\
}})()",
expr = cleaned_expr,
oid = oid,
meta_fn = Self::meta_extract_js("__result"),
err_meta_fn = Self::meta_extract_js("e"),
done_counter = done_counter,
)
} else {
format!(
"(function() {{\n\
var __result;\n\
try {{ __result = (\n{expr}\n); }} catch(e) {{ __result = undefined; }}\n\
globalThis.__obscura_objects['{oid}'] = __result;\n\
return {meta_fn};\n\
}})()",
expr = cleaned_expr,
oid = oid,
meta_fn = Self::meta_extract_js("__result"),
)
};
let result = self
.runtime
.execute_script("<eval-remote>", meta_code)
.map_err(|e| format!("JS error: {}", e))?;
let meta_str = if await_promise {
let __t0 = std::time::Instant::now();
let sentinel = format!("globalThis.__obscura_done_{done_counter} === true");
self.resolve_promises_until(
|rt| rt.runtime.execute_script("<done?>", sentinel.clone())
.ok()
.and_then(|v| rt.v8_to_json(v).ok())
.and_then(|j| j.as_bool())
.unwrap_or(false),
5000,
).await;
let __dt = __t0.elapsed();
if __dt > std::time::Duration::from_secs(1) {
let preview: String = expression
.chars()
.take(200)
.map(|c| if c == '\n' || c == '\t' { ' ' } else { c })
.collect();
tracing::debug!(
"Runtime.evaluate awaitPromise took {}ms; expr={}",
__dt.as_millis(), preview,
);
}
let rejected = self.runtime.execute_script("<readRejected>", "globalThis.__obscura_await_rejected".to_string())
.map_err(|e| format!("JS error: {}", e))?;
if self.v8_to_json(rejected)?.as_bool().unwrap_or(false) {
let err = self.runtime.execute_script("<readError>", format!("String(globalThis.__obscura_objects['{0}'] && (globalThis.__obscura_objects['{0}'].message || globalThis.__obscura_objects['{0}']))", oid))
.map_err(|e| format!("JS error: {}", e))?;
return Err(format!("Promise rejected: {}", self.v8_to_json(err)?.as_str().unwrap_or("")));
}
self.runtime.execute_script("<readMeta>", "globalThis.__obscura_await_meta".to_string())
.map_err(|e| format!("JS error: {}", e))?
} else {
result
};
let meta_str = self.v8_to_json(meta_str)?;
let meta_json = if let serde_json::Value::String(s) = &meta_str {
serde_json::from_str(s).unwrap_or(meta_str)
} else {
meta_str
};
self.object_store.insert(
oid.clone(),
format!("globalThis.__obscura_objects['{}']", oid),
);
if await_promise && return_by_value {
let read = self.runtime.execute_script("<readResult>", format!("globalThis.__obscura_objects['{}']", oid))
.map_err(|e| format!("JS error: {}", e))?;
let json_val = self.v8_to_json(read)?;
return Ok(Self::info_from_json(&json_val));
}
Ok(Self::info_from_meta(&meta_json, Some(oid)))
}
pub async fn call_function_on_for_cdp(
&mut self,
function_declaration: &str,
object_id: Option<&str>,
arguments: &[serde_json::Value],
return_by_value: bool,
await_promise: bool,
) -> Result<RemoteObjectInfo, String> {
let this_expr = self.resolve_this(object_id);
let (setup, args_list) = self.build_args(arguments);
self.object_counter += 1;
let oid = self.make_oid(self.object_counter);
if await_promise {
let done_counter = self.object_counter;
let err_meta_fn = Self::meta_extract_js("__result");
let code = format!(
"(async function() {{\n\
{setup}\n\
var __fn = ({fn_decl});\n\
var __this = ({this_expr});\n\
var __result;\n\
try {{\n\
__result = await __fn.call(__this, {args});\n\
globalThis.__obscura_objects['{oid}'] = __result;\n\
globalThis.__obscura_await_meta = {meta_fn};\n\
}} catch(e) {{\n\
__result = e;\n\
globalThis.__obscura_objects['{oid}'] = e;\n\
globalThis.__obscura_await_meta = {err_meta_fn};\n\
}} finally {{\n\
globalThis.__obscura_done_{done_counter} = true;\n\
}}\n\
}})()",
setup = setup,
fn_decl = function_declaration,
this_expr = this_expr,
args = args_list,
oid = oid,
meta_fn = Self::meta_extract_js("__result"),
err_meta_fn = err_meta_fn,
done_counter = done_counter,
);
self.runtime
.execute_script("<callFnAsync>", code)
.map_err(|e| format!("JS error: {}", e))?;
let __t0 = std::time::Instant::now();
let sentinel = format!("globalThis.__obscura_done_{done_counter} === true");
self.resolve_promises_until(
|rt| rt.runtime.execute_script("<done?>", sentinel.clone())
.ok()
.and_then(|v| rt.v8_to_json(v).ok())
.and_then(|j| j.as_bool())
.unwrap_or(false),
5000,
).await;
let __dt = __t0.elapsed();
if __dt > std::time::Duration::from_secs(1) {
let preview: String = function_declaration
.chars()
.take(300)
.map(|c| if c == '\n' || c == '\t' { ' ' } else { c })
.collect();
tracing::debug!(
"Runtime.callFunctionOn awaitPromise took {}ms; fn={}",
__dt.as_millis(), preview,
);
}
if return_by_value {
let read = self.runtime.execute_script(
"<readResult>",
format!("globalThis.__obscura_objects['{}']", oid),
).map_err(|e| format!("JS error: {}", e))?;
let json_val = self.v8_to_json(read)?;
return Ok(Self::info_from_json(&json_val));
}
let meta_result = self.runtime.execute_script(
"<readMeta>",
"globalThis.__obscura_await_meta".to_string(),
).map_err(|e| format!("JS error: {}", e))?;
let meta_str = self.v8_to_json(meta_result)?;
let meta_json = if let serde_json::Value::String(s) = &meta_str {
serde_json::from_str(s).unwrap_or(meta_str.clone())
} else {
meta_str
};
self.object_store.insert(
oid.clone(),
format!("globalThis.__obscura_objects['{}']", oid),
);
return Ok(Self::info_from_meta(&meta_json, Some(oid)));
}
if return_by_value {
let code = format!(
"(function() {{\n\
{setup}\n\
var __fn = ({fn_decl});\n\
var __this = ({this_expr});\n\
return __fn.call(__this, {args});\n\
}})()",
setup = setup,
fn_decl = function_declaration,
this_expr = this_expr,
args = args_list,
);
let result = self.runtime
.execute_script("<callFnByValue>", code)
.map_err(|e| format!("JS error: {}", e))?;
let json_val = self.v8_to_json(result)?;
return Ok(Self::info_from_json(&json_val));
}
let code = format!(
"(function() {{\n\
{setup}\n\
var __fn = ({fn_decl});\n\
var __this = ({this_expr});\n\
var __result = __fn.call(__this, {args});\n\
globalThis.__obscura_objects['{oid}'] = __result;\n\
return {meta_fn};\n\
}})()",
setup = setup,
fn_decl = function_declaration,
this_expr = this_expr,
args = args_list,
oid = oid,
meta_fn = Self::meta_extract_js("__result"),
);
let result = self.runtime
.execute_script("<callFnRemote>", code)
.map_err(|e| format!("JS error: {}", e))?;
let meta_str = self.v8_to_json(result)?;
let meta_json = if let serde_json::Value::String(s) = &meta_str {
serde_json::from_str(s).unwrap_or(meta_str.clone())
} else {
meta_str
};
self.object_store.insert(
oid.clone(),
format!("globalThis.__obscura_objects['{}']", oid),
);
Ok(Self::info_from_meta(&meta_json, Some(oid)))
}
pub async fn call_function_on(
&mut self,
function_declaration: &str,
object_id: Option<&str>,
arguments: &[serde_json::Value],
return_by_value: bool,
) -> Result<RemoteObjectInfo, String> {
self.call_function_on_for_cdp(function_declaration, object_id, arguments, return_by_value, false).await
}
pub fn store_object(&mut self, js_expression: &str) -> Result<String, String> {
self.object_counter += 1;
let oid = self.make_oid(self.object_counter);
let code = format!(
"globalThis.__obscura_objects['{}'] = ({});",
oid, js_expression,
);
self.runtime
.execute_script("<store>", code)
.map_err(|e| format!("Store error: {}", e))?;
self.object_store.insert(
oid.clone(),
format!("globalThis.__obscura_objects['{}']", oid),
);
Ok(oid)
}
pub fn store_object_with_meta(
&mut self,
js_expression: &str,
) -> Result<RemoteObjectInfo, String> {
self.object_counter += 1;
let oid = self.make_oid(self.object_counter);
let code = format!(
"(function() {{\n\
var __result = (\n{expr}\n);\n\
globalThis.__obscura_objects['{oid}'] = __result;\n\
return {meta_fn};\n\
}})()",
expr = js_expression,
oid = oid,
meta_fn = Self::meta_extract_js("__result"),
);
let result = self
.runtime
.execute_script("<store-meta>", code)
.map_err(|e| format!("Store error: {}", e))?;
let meta_str = self.v8_to_json(result)?;
let meta_json = if let serde_json::Value::String(s) = &meta_str {
serde_json::from_str(s).unwrap_or(meta_str.clone())
} else {
meta_str
};
self.object_store.insert(
oid.clone(),
format!("globalThis.__obscura_objects['{}']", oid),
);
Ok(Self::info_from_meta(&meta_json, Some(oid)))
}
pub fn release_object(&mut self, object_id: &str) {
if self.object_store.remove(object_id).is_some() {
let code = format!(
"delete globalThis.__obscura_objects['{}'];",
object_id,
);
let _ = self.runtime.execute_script("<release>", code);
}
}
pub fn release_object_group(&mut self) {
let _ = self.runtime.execute_script(
"<releaseGroup>",
"globalThis.__obscura_objects = {};".to_string(),
);
self.object_store.clear();
}
pub async fn load_module(&mut self, url: &str, budget_ms: u64) -> Result<(), String> {
let budget = tokio::time::Duration::from_millis(budget_ms);
let specifier = deno_core::ModuleSpecifier::parse(url)
.map_err(|e| format!("Invalid module URL {}: {}", url, e))?;
// Fetch the module source. The old impl registered an empty string
// and called it loaded, so every Vite / Next module bundle "loaded"
// in 1ms with zero code and the SPA never mounted (issue #205).
let client = self.state.borrow().http_client.clone();
let source_code = match client {
Some(c) => match c.fetch(&specifier).await {
Ok(resp) => obscura_net::decode_non_html(&resp.body, resp.content_type()),
Err(e) => {
tracing::warn!("Module fetch failed ({}): {}", url, e);
String::new()
}
},
None => {
tracing::warn!("No http_client wired to runtime; module {} will be empty", url);
String::new()
}
};
// Bound the recursive import-graph fetch. deno_core fetches the graph
// concurrently, but a module whose top-level eval idle-waits forever (no
// CPU, no network) otherwise blocks here until the phase watchdog fires.
// The caller sizes the budget: short for enhancement modules on an
// already-rendered page, full for an unmounted SPA shell (#205).
let module_id = match tokio::time::timeout(
budget,
self.runtime.load_side_es_module_from_code(&specifier, deno_core::ModuleCodeString::from(source_code)),
).await {
Ok(Ok(id)) => id,
Ok(Err(e)) => return Err(format!("Module load error: {}", e)),
Err(_) => {
tracing::warn!("Module graph load timed out after {}ms: {}", budget_ms, url);
return Ok(());
}
};
let result = self.runtime.mod_evaluate(module_id);
let timeout = tokio::time::timeout(
budget,
self.runtime.run_event_loop(deno_core::PollEventLoopOptions::default()),
).await;
match timeout {
Ok(Ok(())) => {}
Ok(Err(e)) => return Err(format!("Module event loop error: {}", e)),
Err(_) => {
tracing::warn!("Module evaluation timed out after {}ms: {}", budget_ms, url);
return Ok(());
}
}
match result.await {
Ok(()) => Ok(()),
Err(e) => {
tracing::warn!("Module eval error: {}", e);
Ok(())
}
}
}
pub async fn load_inline_module(&mut self, code: &str, base_url: &str, budget_ms: u64) -> Result<(), String> {
let budget = tokio::time::Duration::from_millis(budget_ms);
let specifier = deno_core::ModuleSpecifier::parse(
&format!("{}#inline-module-{}", base_url, self.object_counter),
)
.unwrap_or_else(|_| deno_core::ModuleSpecifier::parse("about:blank").unwrap());
self.object_counter += 1;
let module_id = match tokio::time::timeout(
budget,
self.runtime.load_side_es_module_from_code(
&specifier,
deno_core::ModuleCodeString::from(code.to_string()),
),
).await {
Ok(Ok(id)) => id,
Ok(Err(e)) => return Err(format!("Inline module load error: {}", e)),
Err(_) => {
tracing::warn!("Inline module graph load timed out after {}ms", budget_ms);
return Ok(());
}
};
let result = self.runtime.mod_evaluate(module_id);
let timeout = tokio::time::timeout(
budget,
self.runtime.run_event_loop(deno_core::PollEventLoopOptions::default()),
).await;
match timeout {
Ok(Ok(())) => {}
Ok(Err(e)) => return Err(format!("Module event loop error: {}", e)),
Err(_) => {
tracing::warn!("Inline module timed out after {}ms", budget_ms);
return Ok(());
}
}
match result.await {
Ok(()) => Ok(()),
Err(e) => {
tracing::warn!("Inline module eval error: {}", e);
Ok(())
}
}
}
pub fn execute_script(&mut self, _name: &str, source: &str) -> Result<(), String> {
self.runtime
.execute_script("<script>", source.to_string())
.map_err(|e| format!("JS error: {}", e))?;
Ok(())
}
pub fn execute_script_guarded(&mut self, _name: &str, source: &str) -> Result<(), String> {
if source.len() < 10_000 {
self.execute_script(_name, source)
} else {
self.execute_script_with_timeout(source, std::time::Duration::from_secs(5))
}
}
pub fn execute_script_with_timeout(
&mut self,
source: &str,
timeout: std::time::Duration,
) -> Result<(), String> {
if timeout.is_zero() {
self.runtime
.execute_script("<script>", source.to_string())
.map_err(|e| format!("JS error: {}", e))?;
return Ok(());
}
let isolate_handle = self.runtime.v8_isolate().thread_safe_handle();
let pair = std::sync::Arc::new((
std::sync::Mutex::new(false),
std::sync::Condvar::new(),
));
let pair_clone = pair.clone();
let watchdog = std::thread::spawn(move || {
let (lock, cvar) = &*pair_clone;
let mut cancelled = lock.lock().unwrap();
let deadline = std::time::Instant::now() + timeout;
loop {
let remaining = deadline.saturating_duration_since(std::time::Instant::now());
if remaining.is_zero() {
isolate_handle.terminate_execution();
return;
}
let result = cvar.wait_timeout(cancelled, remaining).unwrap();
cancelled = result.0;
if *cancelled {
return;
}
}
});
let result = self
.runtime
.execute_script("<script>", source.to_string());
{
let (lock, cvar) = &*pair;
let mut cancelled = lock.lock().unwrap();
*cancelled = true;
cvar.notify_one();
}
let _ = watchdog.join();
match result {
Ok(_) => Ok(()),
Err(e) => {
let msg = e.to_string();
if msg.contains("Uncaught Error: execution terminated") {
tracing::warn!("Script killed after {}s timeout", timeout.as_secs());
self.runtime.execute_script("<reset>", "undefined".to_string()).ok();
Ok(())
} else {
Err(format!("JS error: {}", msg))
}
}
}
}
pub async fn run_event_loop(&mut self) -> Result<(), String> {
self.runtime
.run_event_loop(deno_core::PollEventLoopOptions::default())
.await
.map_err(|e| format!("Event loop error: {}", e))
}
/// Arm a hard wall-clock backstop on synchronous V8 work. A page stuck in a
/// synchronous loop or a microtask storm pins the OS thread inside V8, so
/// `tokio::time::timeout` (which can only cancel at await points) never
/// fires. This spawns a watchdog thread that terminates the isolate once
/// `budget` elapses, forcing V8 to throw an uncatchable error and hand
/// control back. Always balance with [`Self::disarm_watchdog`].
pub fn arm_watchdog(&mut self, budget: std::time::Duration) -> WatchdogToken {
spawn_watchdog(self.runtime.v8_isolate().thread_safe_handle(), budget)
}
/// Stop a watchdog armed by [`Self::arm_watchdog`]. If it had already fired
/// (terminated the isolate), clear V8's termination flag so the isolate is
/// usable again, and return `true`.
pub fn disarm_watchdog(&mut self, token: WatchdogToken) -> bool {
let fired = token.stop();
if fired {
self.runtime.v8_isolate().cancel_terminate_execution();
tracing::warn!("V8 watchdog fired: terminated a synchronous overrun");
}
fired
}
/// This runtime's V8 isolate handle (captured at construction, stable for
/// the isolate's life). Lets the CDP dispatcher arm a per-command watchdog
/// from `&self`.
pub fn isolate_handle(&self) -> IsolateHandle {
self.isolate_handle.clone()
}
/// Clear V8's termination flag after a watchdog armed externally (via the
/// isolate handle) fired, so the isolate is usable for the next command.
/// No-op when the isolate is not terminating.
pub fn cancel_termination(&mut self) {
self.runtime.v8_isolate().cancel_terminate_execution();
}
/// Drive the event loop for at most `budget_ms`, bounded against BOTH async
/// idle (tokio timeout) and synchronous hangs (V8 watchdog). A microtask
/// storm that pins the thread is terminated ~500ms past the budget; a
/// well-behaved page returns as soon as the loop goes idle.
pub async fn run_event_loop_bounded(&mut self, budget_ms: u64) -> Result<(), String> {
if budget_ms == 0 {
return self.run_event_loop().await;
}
let budget = std::time::Duration::from_millis(budget_ms);
let token = self.arm_watchdog(budget + std::time::Duration::from_millis(500));
let result = tokio::time::timeout(budget, self.run_event_loop()).await;
self.disarm_watchdog(token);
match result {
Ok(Ok(())) => Ok(()),
Ok(Err(e)) if e.contains("execution terminated") => Ok(()),
Ok(Err(e)) => Err(e),
// tokio idle-timeout is the normal "settled" exit, not an error.
Err(_) => Ok(()),
}
}
/// Like [`Self::evaluate`] but bounded by a V8 watchdog, so a `--eval`
/// expression that loops forever (or awaits a promise that never settles in
/// synchronous form) cannot hang the process.
pub fn evaluate_with_timeout(
&mut self,
expression: &str,
timeout: std::time::Duration,
) -> Result<serde_json::Value, String> {
if timeout.is_zero() {
return self.evaluate(expression);
}
let wrapped = Self::wrap_expression(expression);
let token = self.arm_watchdog(timeout);
let result = self.runtime.execute_script("<eval>", wrapped);
let fired = self.disarm_watchdog(token);
match result {
Ok(v) if !fired => self.v8_to_json(v),
Ok(_) => Err("eval timed out".to_string()),
Err(e) => {
let msg = e.to_string();
if fired || msg.contains("execution terminated") {
Err("eval timed out".to_string())
} else {
Err(format!("JS error: {}", msg))
}
}
}
}
pub async fn resolve_promises(&mut self) {
// Default settle: just pump until idle or 5s.
let _ = tokio::time::timeout(
tokio::time::Duration::from_secs(5),
self.runtime.run_event_loop(deno_core::PollEventLoopOptions::default()),
).await;
}
/// Pump the event loop until `done_check` returns true (e.g. an IIFE
/// has written its result sentinel), or `max_total_ms` elapses.
///
/// Why this exists: `run_event_loop(default)` only returns when there is
/// no pending work. Page JS routinely schedules long setTimeouts
/// (IntersectionObserver re-fires at 7s, requestIdleCallback, etc.) that
/// the caller does not care about. With the plain timeout we waited 5s
/// even when the IIFE we cared about resolved in <1ms — the click flow
/// added ~7s per click because Puppeteer's `isIntersectingViewport`
/// disconnects its observer in the callback, but our scheduled
/// re-fires keep the event loop "busy" until they all fire.
pub async fn resolve_promises_until<F>(&mut self, mut done_check: F, max_total_ms: u64)
where
F: FnMut(&mut Self) -> bool,
{
let deadline = tokio::time::Instant::now() + tokio::time::Duration::from_millis(max_total_ms);
let mut tick_ms: u64 = 1;
loop {
if done_check(self) {
return;
}
if tokio::time::Instant::now() >= deadline {
return;
}
// Pump for a short slice. If the loop returns idle in <tick_ms,
// run_event_loop returns Ok and we check the predicate again.
let _ = tokio::time::timeout(
tokio::time::Duration::from_millis(tick_ms),
self.runtime.run_event_loop(deno_core::PollEventLoopOptions::default()),
).await;
// Backoff so a hung promise doesn't burn CPU. Caps at 50ms;
// worst case we miss the result by <50ms.
if tick_ms < 50 { tick_ms = (tick_ms * 2).min(50); }
}
}
pub fn take_dom(&self) -> Option<DomTree> {
self.state.borrow_mut().dom.take()
}
pub fn with_dom<R>(&self, f: impl FnOnce(&DomTree) -> R) -> Option<R> {
let state = self.state.borrow();
state.dom.as_ref().map(f)
}
/// Absolute URLs the page requested via fetch()/XHR, in request order
/// (issue #301). Backs `--dump assets`.
pub fn fetched_urls(&self) -> Vec<String> {
self.state.borrow().fetched_urls.clone()
}
pub fn dom_ref(&self) -> Option<std::cell::Ref<'_, Option<DomTree>>> {
let r = self.state.borrow();
if r.dom.is_some() {
Some(std::cell::Ref::map(r, |s| &s.dom))
} else {
None
}
}
fn make_oid(&self, counter: u64) -> String {
format!("{{\"injectedScriptId\":1,\"id\":{}}}", counter)
}
fn wrap_expression(expression: &str) -> String {
let trimmed = expression.trim();
let is_multi_statement = trimmed.starts_with("var ")
|| trimmed.starts_with("let ")
|| trimmed.starts_with("const ")
|| trimmed.starts_with("if ")
|| trimmed.starts_with("for ")
|| trimmed.starts_with("while ")
|| trimmed.starts_with("return ");
if is_multi_statement {
format!(
"(function() {{ try {{\n{}\n}} catch(e) {{ return null; }} }})()",
expression
)
} else {
// Strip trailing semicolons + whitespace before wrapping in
// `return (...);`. Playwright's utility-script expression is
// an IIFE that ends with `})();` — leaving the `;` in place
// produces `return (...;);`, a SyntaxError. The script fails
// to parse, the catch never fires (parse errors are not
// catchable), and the function silently returns `undefined`.
// Stripping makes the wrapped expression syntactically valid.
//
// The newline before the trailing `)` also terminates any
// `//# sourceURL=...` line comment the caller may have appended
// (Puppeteer's evaluated bundles do).
let cleaned = trimmed.trim_end_matches(|c: char| c == ';' || c.is_whitespace());
format!(
"(function() {{ try {{ return (\n{}\n); }} catch(e) {{ return null; }} }})()",
cleaned
)
}
}
fn meta_extract_js(var_name: &str) -> String {
format!(
r#"(function(v) {{
var t = typeof v;
var st = null, cn = '', desc = '';
if (v === null) {{ t = 'object'; st = 'null'; }}
else if (v === undefined) {{ t = 'undefined'; }}
else if (Array.isArray(v)) {{
st = 'array'; cn = 'Array';
desc = 'Array(' + v.length + ')';
}}
else if (t === 'object' && typeof v._nid === 'number') {{
st = 'node';
cn = v.constructor ? v.constructor.name : 'Node';
if (v.nodeType === 9) cn = 'HTMLDocument';
else if (v.nodeType === 1) cn = 'HTML' + (v.tagName || 'Element').charAt(0) + (v.tagName || 'Element').slice(1).toLowerCase() + 'Element';
desc = v.tagName ? v.tagName.toLowerCase() : (v.nodeName || 'node');
}}
else if (t === 'function') {{
cn = 'Function';
desc = v.name ? 'function ' + v.name + '()' : 'function()';
}}
else if (t === 'object') {{
cn = (v.constructor && v.constructor.name) || 'Object';
desc = cn;
}}
else {{ desc = String(v); }}
return JSON.stringify({{type:t,subtype:st,className:cn,description:desc}});
}})({var_name})"#,
var_name = var_name,
)
}
fn resolve_this(&self, object_id: Option<&str>) -> String {
match object_id {
Some(oid) => {
if let Some(retrieval) = self.object_store.get(oid) {
retrieval.clone()
} else if oid.starts_with("node-") {
let nid = oid.strip_prefix("node-").unwrap_or("0");
format!(
"(function() {{ \
var nid = {}; \
var cache = globalThis._cache || new Map(); \
if (cache.has(nid)) return cache.get(nid); \
return null; \
}})()",
nid
)
} else {
"globalThis".to_string()
}
}
None => "globalThis".to_string(),
}
}
fn build_args(&self, arguments: &[serde_json::Value]) -> (String, String) {
let mut setup_lines = Vec::new();
let mut arg_names = Vec::new();
for (i, arg) in arguments.iter().enumerate() {
let arg_name = format!("__arg{}", i);
if let Some(value) = arg.get("value") {
let json_str = serde_json::to_string(value).unwrap_or_else(|_| "undefined".to_string());
setup_lines.push(format!("var {} = {};", arg_name, json_str));
} else if let Some(oid) = arg.get("objectId").and_then(|v| v.as_str()) {
if let Some(retrieval) = self.object_store.get(oid) {
setup_lines.push(format!("var {} = {};", arg_name, retrieval));
} else {
setup_lines.push(format!("var {} = undefined;", arg_name));
}
} else if let Some(unser) = arg.get("unserializableValue").and_then(|v| v.as_str()) {
setup_lines.push(format!("var {} = {};", arg_name, unser));
} else {
setup_lines.push(format!("var {} = undefined;", arg_name));
}
arg_names.push(arg_name);
}
(setup_lines.join("\n"), arg_names.join(", "))
}
fn v8_to_json(
&mut self,
result: deno_core::v8::Global<deno_core::v8::Value>,
) -> Result<serde_json::Value, String> {
let scope = &mut self.runtime.handle_scope();
let local = deno_core::v8::Local::new(scope, result);
if local.is_undefined() || local.is_null() {
return Ok(serde_json::Value::Null);
}
if local.is_boolean() {
return Ok(serde_json::Value::Bool(local.boolean_value(scope)));
}
if local.is_number() {
let n = local.number_value(scope).unwrap_or(0.0);
return Ok(serde_json::json!(n));
}
if local.is_string() {
let s = local.to_rust_string_lossy(scope);
return Ok(serde_json::Value::String(s));
}
let global = scope.get_current_context().global(scope);
let json_obj_str = deno_core::v8::String::new(scope, "JSON").unwrap();
if let Some(json_obj) = global.get(scope, json_obj_str.into()) {
if let Some(json_obj) = json_obj.to_object(scope) {
let stringify_str = deno_core::v8::String::new(scope, "stringify").unwrap();
if let Some(stringify_fn) = json_obj.get(scope, stringify_str.into()) {
if let Ok(stringify_fn) =
deno_core::v8::Local::<deno_core::v8::Function>::try_from(stringify_fn)
{
let args = [local];
if let Some(result) = stringify_fn.call(scope, json_obj.into(), &args) {
let json_str = result.to_rust_string_lossy(scope);
if let Ok(val) = serde_json::from_str(&json_str) {
return Ok(val);
}
}
}
}
}
}
let s = local.to_rust_string_lossy(scope);
Ok(serde_json::Value::String(s))
}
fn info_from_json(value: &serde_json::Value) -> RemoteObjectInfo {
match value {
serde_json::Value::Null => RemoteObjectInfo {
js_type: "object".into(),
subtype: Some("null".into()),
class_name: String::new(),
description: "null".into(),
object_id: None,
value: Some(serde_json::Value::Null),
},
serde_json::Value::Bool(b) => RemoteObjectInfo {
js_type: "boolean".into(),
subtype: None,
class_name: String::new(),
description: b.to_string(),
object_id: None,
value: Some(value.clone()),
},
serde_json::Value::Number(n) => RemoteObjectInfo {
js_type: "number".into(),
subtype: None,
class_name: String::new(),
description: n.to_string(),
object_id: None,
value: Some(value.clone()),
},
serde_json::Value::String(s) => RemoteObjectInfo {
js_type: "string".into(),
subtype: None,
class_name: String::new(),
description: s.clone(),
object_id: None,
value: Some(value.clone()),
},
serde_json::Value::Array(arr) => RemoteObjectInfo {
js_type: "object".into(),
subtype: Some("array".into()),
class_name: "Array".into(),
description: format!("Array({})", arr.len()),
object_id: None,
value: Some(value.clone()),
},
serde_json::Value::Object(_) => RemoteObjectInfo {
js_type: "object".into(),
subtype: None,
class_name: "Object".into(),
description: "Object".into(),
object_id: None,
value: Some(value.clone()),
},
}
}
fn info_from_meta(
meta: &serde_json::Value,
object_id: Option<String>,
) -> RemoteObjectInfo {
let js_type = meta
.get("type")
.and_then(|v| v.as_str())
.unwrap_or("undefined")
.to_string();
let subtype = meta
.get("subtype")
.and_then(|v| v.as_str())
.map(|s| s.to_string());
let class_name = meta
.get("className")
.and_then(|v| v.as_str())
.unwrap_or("")
.to_string();
let description = meta
.get("description")
.and_then(|v| v.as_str())
.unwrap_or("")
.to_string();
let value = if js_type != "object" && js_type != "function" {
meta.get("description")
.and_then(|v| v.as_str())
.map(|s| serde_json::Value::String(s.to_string()))
} else {
None
};
RemoteObjectInfo {
js_type,
subtype,
class_name,
description,
object_id,
value,
}
}
}
impl Default for ObscuraJsRuntime {
fn default() -> Self {
Self::new()
}
}
#[cfg(test)]
mod tests {
use super::*;
use obscura_dom::parse_html;
fn setup_runtime(html: &str) -> ObscuraJsRuntime {
let dom = parse_html(html);
let rt = ObscuraJsRuntime::new();
rt.set_dom(dom);
rt.set_url("http://example.com/test");
rt.set_title("Test Page");
rt
}
#[test]
fn test_document_title() {
let mut rt = setup_runtime("<html><head><title>Test</title></head><body></body></html>");
let title = rt.evaluate("document.title").unwrap();
assert_eq!(title, serde_json::json!("Test Page"));
}
#[test]
fn test_document_url() {
let mut rt = setup_runtime("<html><body></body></html>");
let url = rt.evaluate("document.URL").unwrap();
assert_eq!(url, serde_json::json!("http://example.com/test"));
}
#[test]
fn test_query_selector() {
let mut rt = setup_runtime("<html><body><h1>Hello</h1><p>World</p></body></html>");
let text = rt.evaluate("document.querySelector('h1').textContent").unwrap();
assert_eq!(text, serde_json::json!("Hello"));
}
#[test]
fn test_query_selector_all() {
let mut rt = setup_runtime("<ul><li>A</li><li>B</li><li>C</li></ul>");
let count = rt.evaluate("document.querySelectorAll('li').length").unwrap();
assert_eq!(count.as_f64().unwrap() as i64, 3);
}
#[test]
fn test_get_element_by_id() {
let mut rt = setup_runtime(r#"<div id="test">Content</div>"#);
let tag = rt.evaluate("document.getElementById('test').tagName").unwrap();
assert_eq!(tag, serde_json::json!("DIV"));
}
#[test]
fn document_fragment_get_element_by_id_searches_descendants() {
let mut rt = setup_runtime(r#"<div id="target">document</div>"#);
let result = rt
.evaluate(
r#"
(() => {
const frag = document.createDocumentFragment();
const section = document.createElement('section');
section.innerHTML = '<div><span id="target">fragment</span></div><p id="a.b">literal</p>';
frag.appendChild(section);
const dup = document.createDocumentFragment();
const deepParent = document.createElement('div');
deepParent.innerHTML = '<span id="dup">deep</span>';
const shallow = document.createElement('p');
shallow.id = 'dup';
shallow.textContent = 'shallow';
dup.appendChild(deepParent);
dup.appendChild(shallow);
return [
frag.getElementById('target').textContent,
frag.getElementById('missing') === null,
frag.getElementById('a.b').textContent,
frag.getElementById(123) === null,
dup.getElementById('dup').textContent,
];
})()
"#,
)
.unwrap();
assert_eq!(
result,
serde_json::json!(["fragment", true, "literal", true, "deep"])
);
}
#[test]
fn test_inner_html() {
let mut rt = setup_runtime(r#"<div id="x"><p>Hello</p></div>"#);
let html = rt.evaluate("document.getElementById('x').innerHTML").unwrap();
assert!(html.as_str().unwrap().contains("<p>"));
}
#[test]
fn test_script_execution() {
let mut rt = setup_runtime("<ul><li>A</li><li>B</li></ul>");
rt.execute_script(
"test",
r#"
globalThis.__result = [];
document.querySelectorAll('li').forEach(function(el) {
globalThis.__result.push(el.textContent);
});
"#,
)
.unwrap();
let result = rt.evaluate("globalThis.__result").unwrap();
assert_eq!(result, serde_json::json!(["A", "B"]));
}
/// Regression test for #147: a TypeError in one script must not poison
/// the runtime so that subsequent scripts (or DOM queries) collapse to
/// empty. The reporter saw `--dump text` return 1 byte after offside.js
/// crashed; that cascade should never happen.
#[test]
fn script_typeerror_does_not_poison_subsequent_execution() {
let mut rt = setup_runtime(
"<html><body><p id=hit>BODY_TEXT</p></body></html>",
);
// 1. First script throws the same flavor of error offside.js produced
// (`Cannot read properties of undefined (reading 'classList')`).
let err = rt
.execute_script("buggy", "var x; x.classList.add('y');")
.unwrap_err();
assert!(err.contains("classList") || err.contains("undefined"),
"expected classList/undefined error, got: {}", err);
// 2. The runtime must still be usable: a follow-up script runs.
rt.execute_script("ok", "globalThis.__after_error = 'still alive';")
.unwrap();
let result = rt.evaluate("globalThis.__after_error").unwrap();
assert_eq!(result, serde_json::json!("still alive"));
// 3. DOM queries still work after the script error.
let text = rt
.evaluate("document.querySelector('#hit').textContent")
.unwrap();
assert_eq!(text, serde_json::json!("BODY_TEXT"));
}
/// Regression for #105: `element.querySelector` and `querySelectorAll`
/// must scope to the receiver's subtree, not the whole document.
#[test]
fn element_query_selector_is_scoped_to_subtree() {
let mut rt = setup_runtime(
r#"<div id="a"><span class="x">in a</span></div><div id="b"><span class="x">in b</span></div>"#,
);
let text = rt
.evaluate("document.getElementById('a').querySelector('.x').textContent")
.unwrap();
assert_eq!(text, serde_json::json!("in a"));
let count_in_a = rt
.evaluate("document.getElementById('a').querySelectorAll('.x').length")
.unwrap();
assert_eq!(count_in_a.as_f64().unwrap() as i64, 1);
// Document-scoped query still sees both.
let count_doc = rt.evaluate("document.querySelectorAll('.x').length").unwrap();
assert_eq!(count_doc.as_f64().unwrap() as i64, 2);
}
#[test]
fn document_evaluate_exposes_basic_xpath_result() {
let mut rt = setup_runtime("");
let exposed = rt
.evaluate("`${typeof XPathResult}:${typeof Document.prototype.evaluate}:${XPathResult.FIRST_ORDERED_NODE_TYPE}`")
.unwrap();
assert_eq!(exposed, serde_json::json!("function:function:9"));
}
/// Regression for #105: `document.forms` / `images` / `links` must be
/// live, not hardcoded `[]`. jQuery 1.x's submit-event setup iterates
/// `document.forms` and crashes when it's empty for pages that have forms.
#[test]
fn document_forms_images_links_are_live() {
let mut rt = setup_runtime(
r#"<form></form><form></form><img><a href="x">l</a><a>no-href</a>"#,
);
assert_eq!(rt.evaluate("document.forms.length").unwrap().as_f64().unwrap() as i64, 2);
assert_eq!(rt.evaluate("document.images.length").unwrap().as_f64().unwrap() as i64, 1);
assert_eq!(rt.evaluate("document.links.length").unwrap().as_f64().unwrap() as i64, 1);
}
/// Regression for #105: `HTMLFormElement` must expose `.elements` so
/// frameworks that probe form field collections work.
#[test]
fn html_form_element_exposes_elements_collection() {
let mut rt = setup_runtime(
r#"<form id="f"><input name=a><input name=b><textarea></textarea></form>"#,
);
let n = rt
.evaluate("document.getElementById('f').elements.length")
.unwrap();
assert_eq!(n.as_f64().unwrap() as i64, 3);
let is_form = rt
.evaluate("document.getElementById('f') instanceof HTMLFormElement")
.unwrap();
assert_eq!(is_form, serde_json::json!(true));
}
/// Regression for #105: `Element.prepend` must actually insert at the
/// start, not silently no-op.
#[test]
fn element_prepend_inserts_at_start() {
let mut rt = setup_runtime(r#"<div id="c"><span>existing</span></div>"#);
rt.evaluate(
r#"
const c = document.getElementById('c');
const n = document.createElement('span');
n.id = 'first';
c.prepend(n);
"#,
)
.unwrap();
let first_id = rt.evaluate("document.getElementById('c').firstChild.id").unwrap();
assert_eq!(first_id, serde_json::json!("first"));
let count = rt.evaluate("document.getElementById('c').childNodes.length").unwrap();
assert_eq!(count.as_f64().unwrap() as i64, 2);
}
/// Regression for #105: `isEqualNode` compares structure, not identity.
/// Framework diff algorithms rely on this.
#[test]
fn is_equal_node_does_structural_compare() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt
.evaluate(
r#"
const a = document.createElement('div'); a.setAttribute('class', 'x'); a.innerHTML = '<span>hi</span>';
const b = document.createElement('div'); b.setAttribute('class', 'x'); b.innerHTML = '<span>hi</span>';
const c = document.createElement('div'); c.innerHTML = '<span>bye</span>';
return [a.isEqualNode(b), a.isEqualNode(c), a.isSameNode(b)];
"#,
)
.unwrap();
assert_eq!(result, serde_json::json!([true, false, false]));
}
/// Regression for the long-standing insert_before arg-order bug noted
/// in CLAUDE.md: bootstrap.js was passing (parent, new, ref) but `_dom`
/// forwards only two args, silently dropping `ref`. With the fix,
/// `insertBefore` actually inserts.
#[test]
fn insert_before_inserts_node_at_correct_position() {
let mut rt = setup_runtime(r#"<div id="p"><span id="b">b</span><span id="c">c</span></div>"#);
let order = rt
.evaluate(
r#"
const p = document.getElementById('p');
const a = document.createElement('span');
a.id = 'a';
p.insertBefore(a, document.getElementById('b'));
return Array.from(p.children).map(e => e.id).join(',');
"#,
)
.unwrap();
assert_eq!(order, serde_json::json!("a,b,c"));
}
#[test]
fn test_console_log() {
let mut rt = setup_runtime("<html><body></body></html>");
rt.execute_script("test", "console.log('Hello from V8!')").unwrap();
}
#[test]
fn test_location() {
let mut rt = setup_runtime("<html><body></body></html>");
let href = rt.evaluate("location.href").unwrap();
assert_eq!(href, serde_json::json!("http://example.com/test"));
}
#[test]
fn test_button_click_dispatches_listener() {
let mut rt = setup_runtime(r#"<button id="go">Go</button>"#);
let result = rt.evaluate(r#"
const button = document.getElementById('go');
button.addEventListener('click', () => { button.dataset.clicked = 'yes'; });
button.click();
return button.dataset.clicked;
"#).unwrap();
assert_eq!(result, serde_json::json!("yes"));
}
#[test]
fn test_dispatch_mouse_event_runs_listener() {
let mut rt = setup_runtime(r#"<button id="go">Go</button>"#);
let result = rt.evaluate(r#"
const button = document.getElementById('go');
let count = 0;
button.addEventListener('click', () => { count += 1; });
button.dispatchEvent(new MouseEvent('click', { bubbles: true }));
return count;
"#).unwrap();
assert_eq!(result.as_f64().unwrap() as i64, 1);
}
#[test]
fn test_location_href_assignment_updates_navigation_state() {
let mut rt = setup_runtime("<html><body></body></html>");
let href = rt.evaluate("const next = '/next'; location.href = next; return location.href;").unwrap();
assert_eq!(href, serde_json::json!("http://example.com/next"));
assert_eq!(
rt.take_pending_navigation(),
Some(("http://example.com/next".to_string(), "GET".to_string(), "".to_string()))
);
}
#[test]
fn test_submit_button_click_handler_can_prevent_default_and_navigate() {
let mut rt = setup_runtime(r#"<form><button type="submit" id="submit">Submit</button></form>"#);
let href = rt.evaluate(r#"
const form = document.querySelector('form');
form.addEventListener('submit', (event) => {
event.preventDefault();
location.href = '/submitted';
});
document.getElementById('submit').click();
return location.href;
"#).unwrap();
assert_eq!(href, serde_json::json!("http://example.com/submitted"));
assert_eq!(
rt.take_pending_navigation(),
Some(("http://example.com/submitted".to_string(), "GET".to_string(), "".to_string()))
);
}
#[test]
fn test_navigator() {
let mut rt = setup_runtime("<html><body></body></html>");
let ua = rt.evaluate("navigator.userAgent").unwrap();
assert!(ua.as_str().unwrap().contains("Chrome"), "UA should contain Chrome: {}", ua);
let wd = rt.evaluate("navigator.webdriver").unwrap();
assert_eq!(wd, serde_json::json!(false));
let plugins = rt.evaluate("navigator.plugins.length").unwrap();
assert!(plugins.as_f64().unwrap() > 0.0, "Should have plugins");
let chrome = rt.evaluate("typeof window.chrome").unwrap();
assert_eq!(chrome, serde_json::json!("object"));
}
#[tokio::test(flavor = "current_thread")]
async fn test_call_function_on_no_args() {
let mut rt = setup_runtime("<html><head><title>Test</title></head><body></body></html>");
let result = rt
.call_function_on("() => document.title", None, &[], true)
.await.unwrap();
assert_eq!(result.value.unwrap(), serde_json::json!("Test Page"));
}
#[tokio::test(flavor = "current_thread")]
async fn test_call_function_on_with_args() {
let mut rt = setup_runtime("<html><body></body></html>");
let args = vec![
serde_json::json!({"value": 10}),
serde_json::json!({"value": 20}),
];
let result = rt.call_function_on("(a, b) => a + b", None, &args, true).await.unwrap();
assert_eq!(result.value.unwrap().as_f64().unwrap() as i64, 30);
}
#[tokio::test(flavor = "current_thread")]
async fn test_call_function_on_with_string_args() {
let mut rt = setup_runtime("<html><body></body></html>");
let args = vec![
serde_json::json!({"value": "hello"}),
serde_json::json!({"value": " world"}),
];
let result = rt.call_function_on("(a, b) => a + b", None, &args, true).await.unwrap();
assert_eq!(result.value.unwrap(), serde_json::json!("hello world"));
}
#[tokio::test(flavor = "current_thread")]
async fn test_call_function_on_with_object_args() {
let mut rt = setup_runtime("<html><body></body></html>");
let args = vec![serde_json::json!({"value": {"name": "test", "count": 5}})];
let result = rt
.call_function_on("(obj) => obj.name + ':' + obj.count", None, &args, true)
.await.unwrap();
assert_eq!(result.value.unwrap(), serde_json::json!("test:5"));
}
#[tokio::test(flavor = "current_thread")]
async fn test_call_function_on_return_object() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt
.call_function_on("() => ({a: 1, b: 2})", None, &[], true)
.await.unwrap();
assert_eq!(result.value.unwrap(), serde_json::json!({"a": 1, "b": 2}));
}
#[tokio::test(flavor = "current_thread")]
async fn test_call_function_on_object_ref_preserves_methods() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt
.call_function_on(
"() => ({ items: [1,2,3], getLen: function() { return this.items.length; } })",
None,
&[],
false,
)
.await.unwrap();
let oid = result.object_id.unwrap();
let result2 = rt
.call_function_on("function() { return this.getLen(); }", Some(&oid), &[], true)
.await.unwrap();
assert_eq!(result2.value.unwrap().as_f64().unwrap() as i64, 3);
}
#[tokio::test(flavor = "current_thread")]
async fn test_evaluate_for_cdp_detects_node() {
let mut rt = setup_runtime("<html><body><h1>Hello</h1></body></html>");
let result = rt
.evaluate_for_cdp("document.querySelector('h1')", false, false)
.await.unwrap();
assert_eq!(result.subtype.as_deref(), Some("node"));
assert_eq!(result.js_type, "object");
assert!(result.object_id.is_some());
}
#[tokio::test(flavor = "current_thread")]
async fn test_evaluate_for_cdp_detects_document() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate_for_cdp("document", false, false).await.unwrap();
assert_eq!(result.subtype.as_deref(), Some("node"));
assert_eq!(result.class_name, "HTMLDocument");
}
#[tokio::test(flavor = "current_thread")]
async fn test_evaluate_for_cdp_awaits_resolved_promise() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate_for_cdp("Promise.resolve(42)", true, true).await.unwrap();
assert_eq!(result.value.unwrap().as_f64().unwrap() as i64, 42);
}
#[tokio::test(flavor = "current_thread")]
async fn test_evaluate_for_cdp_awaits_timer_promise() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate_for_cdp("new Promise(resolve => setTimeout(() => resolve('done'), 1))", true, true).await.unwrap();
assert_eq!(result.value.unwrap().as_str().unwrap(), "done");
}
#[tokio::test(flavor = "current_thread")]
async fn test_evaluate_for_cdp_awaits_async_function() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate_for_cdp("(async () => 'async-ok')()", true, true).await.unwrap();
assert_eq!(result.value.unwrap().as_str().unwrap(), "async-ok");
}
#[tokio::test(flavor = "current_thread")]
async fn test_evaluate_for_cdp_reports_promise_rejection() {
let mut rt = setup_runtime("<html><body></body></html>");
let err = rt.evaluate_for_cdp("Promise.reject(new Error('boom'))", true, true).await.unwrap_err();
assert!(err.contains("boom"));
}
#[tokio::test(flavor = "current_thread")]
async fn test_call_function_on_dom_interaction() {
let mut rt = setup_runtime(r#"<div id="items"><span>A</span><span>B</span></div>"#);
let args = vec![serde_json::json!({"value": "span"})];
let result = rt
.call_function_on(
"(sel) => document.querySelectorAll(sel).length",
None,
&args,
true,
)
.await.unwrap();
assert_eq!(result.value.unwrap().as_f64().unwrap() as i64, 2);
}
#[test]
fn test_inner_html_setter() {
let mut rt = setup_runtime(r#"<div id="target"><p>Old</p></div>"#);
rt.execute_script("test", r#"
var el = document.getElementById('target');
el.innerHTML = '<strong>Bold</strong><em>Italic</em>';
"#).unwrap();
let result = rt.evaluate("document.getElementById('target').innerHTML").unwrap();
let html = result.as_str().unwrap();
assert!(html.contains("<strong>"), "innerHTML should contain <strong>, got: {}", html);
assert!(html.contains("<em>"), "innerHTML should contain <em>, got: {}", html);
assert!(!html.contains("Old"), "innerHTML should not contain old content, got: {}", html);
}
#[test]
fn test_inner_html_with_nested() {
let mut rt = setup_runtime(r#"<div id="root"></div>"#);
rt.execute_script("test", r#"
var el = document.getElementById('root');
el.innerHTML = '<ul><li>A</li><li>B</li><li>C</li></ul>';
"#).unwrap();
let count = rt.evaluate("document.querySelectorAll('li').length").unwrap();
assert_eq!(count.as_f64().unwrap() as i64, 3, "Should find 3 li elements after innerHTML set");
let text = rt.evaluate("document.querySelector('li').textContent").unwrap();
assert_eq!(text, serde_json::json!("A"));
}
#[test]
fn test_input_value() {
let mut rt = setup_runtime(r#"<form><input id="name" type="text" value="initial"><textarea id="bio">old text</textarea></form>"#);
let val = rt.evaluate("document.getElementById('name').value").unwrap();
assert_eq!(val, serde_json::json!("initial"));
rt.execute_script("test", "document.getElementById('name').value = 'new value';").unwrap();
let val2 = rt.evaluate("document.getElementById('name').value").unwrap();
assert_eq!(val2, serde_json::json!("new value"));
let bio = rt.evaluate("document.getElementById('bio').value").unwrap();
assert_eq!(bio, serde_json::json!("old text"));
}
#[test]
fn test_sequential_runtime_swap() {
let mut rt1 = setup_runtime("<html><body><h1>Page1</h1></body></html>");
let title1 = rt1.evaluate("document.querySelector('h1').textContent").unwrap();
assert_eq!(title1, serde_json::json!("Page1"));
let dom1 = rt1.take_dom();
drop(rt1);
let mut rt2 = setup_runtime("<html><body><h1>Page2</h1></body></html>");
let title2 = rt2.evaluate("document.querySelector('h1').textContent").unwrap();
assert_eq!(title2, serde_json::json!("Page2"));
drop(rt2);
if let Some(dom) = dom1 {
let rt1b = ObscuraJsRuntime::new();
rt1b.set_dom(dom);
rt1b.set_url("http://example.com");
rt1b.set_title("Page1");
let mut rt1b = rt1b;
let title1b = rt1b.evaluate("document.querySelector('h1').textContent").unwrap();
assert_eq!(title1b, serde_json::json!("Page1"));
}
}
#[test]
fn test_checkbox_checked() {
let mut rt = setup_runtime(r#"<input id="cb" type="checkbox" checked>"#);
let checked = rt.evaluate("document.getElementById('cb').checked").unwrap();
assert_eq!(checked, serde_json::json!(true));
rt.execute_script("test", "document.getElementById('cb').checked = false;").unwrap();
let checked2 = rt.evaluate("document.getElementById('cb').checked").unwrap();
assert_eq!(checked2, serde_json::json!(false));
}
// Issue #324: React/Preact/Vue install a value tracker by redefining `value`
// on the element instance so they can tell a real edit from their own
// controlled write. __obscura_setFieldValue must write through the prototype
// setter, leaving that per-instance tracker stale, so the following input
// event reads as a genuine change and onChange fires. A plain assignment
// keeps the tracker in sync and suppresses onChange.
#[test]
fn set_field_value_bypasses_instance_value_wrapper() {
let mut rt = setup_runtime(r#"<input id="i">"#);
let result = rt
.evaluate(
r#"
(function(){
var el = document.getElementById('i');
var d = Object.getOwnPropertyDescriptor(el.constructor.prototype, 'value');
var set = d.set, get = d.get, tracked = '' + el.value;
Object.defineProperty(el, 'value', {
configurable: true,
get: function(){ return get.call(this); },
set: function(v){ tracked = '' + v; set.call(this, v); },
});
el.value = 'wrapped';
var afterDirect = { value: el.value, tracked: tracked };
globalThis.__obscura_setFieldValue(el, 'value', 'native');
var afterHelper = { value: el.value, tracked: tracked };
return JSON.stringify({ afterDirect: afterDirect, afterHelper: afterHelper });
})()
"#,
)
.unwrap();
let parsed: serde_json::Value = serde_json::from_str(result.as_str().unwrap()).unwrap();
// Direct assignment keeps tracker == value (the change that suppresses onChange).
assert_eq!(parsed["afterDirect"]["value"], "wrapped");
assert_eq!(parsed["afterDirect"]["tracked"], "wrapped");
// The helper updates the value but leaves the tracker stale, so onChange fires.
assert_eq!(parsed["afterHelper"]["value"], "native");
assert_eq!(parsed["afterHelper"]["tracked"], "wrapped");
}
// Issue #324: React feature-detects the modern input-event path with
// `('oninput' in document)`. If the GlobalEventHandlers on* attributes are
// only on window (not Document/Element), that check fails and React falls
// back to a legacy change-detection path, so controlled-input onChange never
// fires. These must be present on document and Element.prototype too.
#[test]
fn global_event_handlers_present_on_document_and_element() {
let mut rt = setup_runtime("<div></div>");
let result = rt
.evaluate(
r#"JSON.stringify({
docInput: ('oninput' in document),
docChange: ('onchange' in document),
docClick: ('onclick' in document),
elProtoInput: ('oninput' in Element.prototype),
winInput: ('oninput' in window)
})"#,
)
.unwrap();
let p: serde_json::Value = serde_json::from_str(result.as_str().unwrap()).unwrap();
assert_eq!(p["docInput"], true);
assert_eq!(p["docChange"], true);
assert_eq!(p["docClick"], true);
assert_eq!(p["elProtoInput"], true);
assert_eq!(p["winInput"], true);
}
#[test]
fn test_matches_and_closest() {
let mut rt = setup_runtime(r#"<div class="outer"><div class="inner"><span id="target">Hi</span></div></div>"#);
let matches = rt.evaluate("document.getElementById('target').matches('span')").unwrap();
assert_eq!(matches, serde_json::json!(true));
let closest = rt.evaluate("document.getElementById('target').closest('.outer').className").unwrap();
assert_eq!(closest, serde_json::json!("outer"));
let no_match = rt.evaluate("document.getElementById('target').closest('.nonexistent')").unwrap();
assert_eq!(no_match, serde_json::Value::Null);
}
#[test]
fn test_clone_node_deep() {
let mut rt = setup_runtime(r#"<div id="src"><p>A</p><p>B</p></div>"#);
rt.execute_script("test", r#"
var src = document.getElementById('src');
var clone = src.cloneNode(true);
document.body.appendChild(clone);
"#).unwrap();
let count = rt.evaluate("document.querySelectorAll('p').length").unwrap();
assert!(count.as_f64().unwrap() as i64 >= 4, "Deep clone should duplicate <p> children, got: {}", count);
}
#[test]
fn test_evaluate_multistatement() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate("var x = 5; var y = 10; return x + y;").unwrap();
assert_eq!(result.as_f64().unwrap() as i64, 15);
}
#[tokio::test(flavor = "current_thread")]
async fn test_object_ref_as_argument() {
let mut rt = setup_runtime("<html><body></body></html>");
let obj = rt
.call_function_on("() => ({ x: 42 })", None, &[], false)
.await.unwrap();
let oid = obj.object_id.unwrap();
let args = vec![serde_json::json!({"objectId": oid})];
let result = rt
.call_function_on("(obj) => obj.x * 2", None, &args, true)
.await.unwrap();
assert_eq!(result.value.unwrap().as_f64().unwrap() as i64, 84);
}
fn setup_runtime_with_cookies(html: &str) -> (ObscuraJsRuntime, std::sync::Arc<obscura_net::CookieJar>) {
let dom = obscura_dom::parse_html(html);
let jar = std::sync::Arc::new(obscura_net::CookieJar::new());
let rt = ObscuraJsRuntime::new();
rt.set_dom(dom);
rt.set_url("http://example.com/test");
rt.set_title("Test Page");
rt.set_cookie_jar(jar.clone());
(rt, jar)
}
#[test]
fn test_document_cookie_reads_http_cookies() {
let (mut rt, jar) = setup_runtime_with_cookies("<html><body></body></html>");
let url = url::Url::parse("http://example.com/test").unwrap();
jar.set_cookie("session=abc123; Path=/", &url);
jar.set_cookie("theme=dark; Path=/", &url);
let result = rt.evaluate("document.cookie").unwrap();
let cookie_str = result.as_str().unwrap();
assert!(cookie_str.contains("session=abc123"), "expected session cookie, got: {}", cookie_str);
assert!(cookie_str.contains("theme=dark"), "expected theme cookie, got: {}", cookie_str);
}
#[test]
fn test_document_cookie_excludes_httponly() {
let (mut rt, jar) = setup_runtime_with_cookies("<html><body></body></html>");
let url = url::Url::parse("http://example.com/test").unwrap();
jar.set_cookie("visible=yes; Path=/", &url);
jar.set_cookie("secret=token; Path=/; HttpOnly", &url);
let result = rt.evaluate("document.cookie").unwrap();
let cookie_str = result.as_str().unwrap();
assert!(cookie_str.contains("visible=yes"), "expected visible cookie, got: {}", cookie_str);
assert!(!cookie_str.contains("secret"), "httpOnly cookie should not be visible to JS, got: {}", cookie_str);
}
#[test]
fn test_document_cookie_setter_stores_in_jar() {
let (mut rt, jar) = setup_runtime_with_cookies("<html><body></body></html>");
rt.evaluate("document.cookie = 'foo=bar; Path=/'").unwrap();
let url = url::Url::parse("http://example.com/test").unwrap();
let result = rt.evaluate("document.cookie").unwrap();
assert!(result.as_str().unwrap().contains("foo=bar"));
let header = jar.get_cookie_header(&url);
assert!(header.contains("foo=bar"), "cookie should be in jar, got: {}", header);
}
#[test]
fn test_document_cookie_delete_via_max_age() {
let (mut rt, jar) = setup_runtime_with_cookies("<html><body></body></html>");
let url = url::Url::parse("http://example.com/test").unwrap();
rt.evaluate("document.cookie = 'temp=val; Path=/'").unwrap();
assert!(rt.evaluate("document.cookie").unwrap().as_str().unwrap().contains("temp=val"));
rt.evaluate("document.cookie = 'temp=; Max-Age=0'").unwrap();
let result = rt.evaluate("document.cookie").unwrap();
assert!(!result.as_str().unwrap().contains("temp="), "cookie should be deleted, got: {}", result);
assert!(!jar.get_cookie_header(&url).contains("temp="));
}
#[test]
fn test_document_cookie_js_and_http_merge() {
let (mut rt, jar) = setup_runtime_with_cookies("<html><body></body></html>");
let url = url::Url::parse("http://example.com/test").unwrap();
jar.set_cookie("server_sid=xyz; Path=/", &url);
rt.evaluate("document.cookie = 'client_pref=light'").unwrap();
let result = rt.evaluate("document.cookie").unwrap();
let cookie_str = result.as_str().unwrap();
assert!(cookie_str.contains("server_sid=xyz"), "expected server cookie, got: {}", cookie_str);
assert!(cookie_str.contains("client_pref=light"), "expected client cookie, got: {}", cookie_str);
}
#[test]
fn test_document_cookie_empty_when_no_cookies() {
let (mut rt, _jar) = setup_runtime_with_cookies("<html><body></body></html>");
let result = rt.evaluate("document.cookie").unwrap();
assert_eq!(result.as_str().unwrap(), "");
}
#[test]
fn test_document_cookie_no_jar_returns_empty() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate("document.cookie").unwrap();
assert_eq!(result.as_str().unwrap(), "");
}
#[test]
fn test_document_write_appends_to_body() {
let mut rt = setup_runtime("<html><body><p>Existing</p></body></html>");
rt.evaluate("document.write('<div>Added</div>')").unwrap();
let html = rt.evaluate("document.body.innerHTML").unwrap();
let body = html.as_str().unwrap();
assert!(body.contains("Existing"), "existing content should remain, got: {}", body);
assert!(body.contains("Added"), "written content should appear, got: {}", body);
}
#[test]
fn test_document_writeln() {
let mut rt = setup_runtime("<html><body></body></html>");
rt.evaluate("document.writeln('Hello')").unwrap();
let html = rt.evaluate("document.body.innerHTML").unwrap();
assert!(html.as_str().unwrap().contains("Hello"));
}
#[test]
fn test_document_write_multiple_args() {
let mut rt = setup_runtime("<html><body></body></html>");
rt.evaluate("document.write('Hello', ' ', 'World')").unwrap();
let text = rt.evaluate("document.body.textContent").unwrap();
assert_eq!(text.as_str().unwrap().trim(), "Hello World");
}
#[test]
fn test_document_open_clears_body() {
let mut rt = setup_runtime("<html><body><p>Old content</p></body></html>");
rt.evaluate("document.open()").unwrap();
let html = rt.evaluate("document.body.innerHTML").unwrap();
assert_eq!(html.as_str().unwrap(), "");
}
#[test]
fn test_document_write_html_elements() {
let mut rt = setup_runtime("<html><body></body></html>");
rt.evaluate(r#"document.write('<h1 id="title">Test</h1><p>Para</p>')"#).unwrap();
let h1 = rt.evaluate("document.querySelector('h1').textContent").unwrap();
assert_eq!(h1.as_str().unwrap(), "Test");
let p = rt.evaluate("document.querySelector('p').textContent").unwrap();
assert_eq!(p.as_str().unwrap(), "Para");
}
#[test]
fn test_url_relative_resolution() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate("new URL('data.json', 'http://example.com/path/page.html').href").unwrap();
assert_eq!(result.as_str().unwrap(), "http://example.com/path/data.json");
let result = rt.evaluate("new URL('/api/data', 'http://example.com/path/page.html').href").unwrap();
assert_eq!(result.as_str().unwrap(), "http://example.com/api/data");
let result = rt.evaluate("new URL('https://other.com/foo', 'http://example.com/bar').href").unwrap();
assert_eq!(result.as_str().unwrap(), "https://other.com/foo");
let result = rt.evaluate("new URL('sub/file.js', 'http://example.com/a/b/c.html').href").unwrap();
assert_eq!(result.as_str().unwrap(), "http://example.com/a/b/sub/file.js");
let result = rt.evaluate("new URL('api.json', 'http://localhost:8080/dir/index.html').href").unwrap();
assert_eq!(result.as_str().unwrap(), "http://localhost:8080/dir/api.json");
}
#[tokio::test(flavor = "current_thread")]
async fn test_fetch_url_input_decodes_binary_body_base64() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.call_function_on_for_cdp(
r#"async () => {
const originalFetchOp = Deno.core.ops.op_fetch_url;
try {
Deno.core.ops.op_fetch_url = (url) => {
globalThis.__capturedFetchUrl = url;
return JSON.stringify({
status: 200,
headers: { "content-type": "application/wasm" },
bodyBase64: "AGFzbQEAAAA=",
url,
});
};
const response = await fetch(new URL("/pkg/app_bg.wasm", document.URL));
const bytes = Array.from(new Uint8Array(await response.arrayBuffer()));
return { url: globalThis.__capturedFetchUrl, bytes };
} finally {
Deno.core.ops.op_fetch_url = originalFetchOp;
}
}"#,
None,
&[],
true,
true,
).await.unwrap();
assert_eq!(
result.value.unwrap(),
serde_json::json!({
"url": "http://example.com/pkg/app_bg.wasm",
"bytes": [0, 97, 115, 109, 1, 0, 0, 0],
})
);
}
#[tokio::test(flavor = "current_thread")]
async fn test_response_array_buffer_preserves_typed_array_view() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.call_function_on_for_cdp(
r#"async () => {
const bytes = new Uint8Array([9, 0, 97, 115, 109, 1, 8]);
const response = new Response(bytes.subarray(1, 6));
return Array.from(new Uint8Array(await response.arrayBuffer()));
}"#,
None,
&[],
true,
true,
).await.unwrap();
assert_eq!(result.value.unwrap(), serde_json::json!([0, 97, 115, 109, 1]));
}
#[tokio::test(flavor = "current_thread")]
async fn test_wasm_instantiate_streaming_uses_response_array_buffer() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.call_function_on_for_cdp(
r#"async () => {
const bytes = new Uint8Array([0, 97, 115, 109, 1, 0, 0, 0]);
const result = await WebAssembly.instantiateStreaming(
Promise.resolve(new Response(bytes)),
{},
);
return result.instance instanceof WebAssembly.Instance;
}"#,
None,
&[],
true,
true,
).await.unwrap();
assert_eq!(result.value.unwrap(), serde_json::json!(true));
}
#[test]
fn test_text_decoder_respects_typed_array_view() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate(
"new TextDecoder().decode(new Uint8Array([65, 66, 67]).subarray(1, 2))"
).unwrap();
assert_eq!(result.as_str().unwrap(), "B");
}
#[test]
fn test_document_doctype() {
let mut rt = setup_runtime("<!DOCTYPE html><html><body></body></html>");
let result = rt.evaluate("document.doctype !== null").unwrap();
assert_eq!(result, serde_json::json!(true));
let name = rt.evaluate("document.doctype.name").unwrap();
assert_eq!(name, serde_json::json!("html"));
let node_type = rt.evaluate("document.doctype.nodeType").unwrap();
assert_eq!(node_type.as_f64().unwrap() as i64, 10);
}
#[test]
fn test_document_doctype_null_when_missing() {
let mut rt = setup_runtime("<html><body></body></html>");
let result = rt.evaluate("document.doctype === null").unwrap();
assert_eq!(result, serde_json::json!(true));
}
#[test]
fn test_xml_serializer_doctype() {
let mut rt = setup_runtime("<!DOCTYPE html><html><body></body></html>");
let result = rt.evaluate(
"new XMLSerializer().serializeToString(document.doctype)"
).unwrap();
assert_eq!(result.as_str().unwrap(), "<!DOCTYPE html>");
}
#[test]
fn test_xml_serializer_element() {
let mut rt = setup_runtime(r#"<html><body><div id="x">Hello</div></body></html>"#);
let result = rt.evaluate(
"new XMLSerializer().serializeToString(document.getElementById('x'))"
).unwrap();
let html = result.as_str().unwrap();
assert!(html.contains("<div"));
assert!(html.contains("Hello"));
}
#[test]
fn test_create_event_custom_event_has_init_method() {
let mut rt = setup_runtime("<html><body></body></html>");
let kind = rt
.evaluate("typeof document.createEvent('CustomEvent').initCustomEvent")
.unwrap();
assert_eq!(kind, serde_json::json!("function"));
}
#[test]
fn test_init_custom_event_sets_fields() {
let mut rt = setup_runtime("<html><body></body></html>");
rt.execute_script(
"test",
r#"
globalThis.__e = document.createEvent('CustomEvent');
globalThis.__e.initCustomEvent('myevent', true, false, {hello: 'world'});
"#,
)
.unwrap();
let t = rt.evaluate("globalThis.__e.type").unwrap();
assert_eq!(t, serde_json::json!("myevent"));
let b = rt.evaluate("globalThis.__e.bubbles").unwrap();
assert_eq!(b, serde_json::json!(true));
let c = rt.evaluate("globalThis.__e.cancelable").unwrap();
assert_eq!(c, serde_json::json!(false));
let d = rt.evaluate("globalThis.__e.detail.hello").unwrap();
assert_eq!(d, serde_json::json!("world"));
}
#[test]
fn test_create_event_returns_correct_class() {
let mut rt = setup_runtime("<html><body></body></html>");
let cust = rt
.evaluate("document.createEvent('CustomEvent') instanceof CustomEvent")
.unwrap();
assert_eq!(cust, serde_json::json!(true));
let mouse = rt
.evaluate("document.createEvent('MouseEvent') instanceof MouseEvent")
.unwrap();
assert_eq!(mouse, serde_json::json!(true));
let mouses = rt
.evaluate("document.createEvent('MouseEvents') instanceof MouseEvent")
.unwrap();
assert_eq!(mouses, serde_json::json!(true));
let kb = rt
.evaluate("document.createEvent('KeyboardEvent') instanceof KeyboardEvent")
.unwrap();
assert_eq!(kb, serde_json::json!(true));
}
#[test]
fn test_create_event_unknown_type_returns_event() {
let mut rt = setup_runtime("<html><body></body></html>");
let kind = rt
.evaluate("document.createEvent('NotARealType') instanceof Event")
.unwrap();
assert_eq!(kind, serde_json::json!(true));
}
#[test]
fn test_html_to_markdown_headings() {
let mut rt = setup_runtime("<html><body><h1>Title</h1><h2>Sub</h2><p>Body</p></body></html>");
let md = rt
.evaluate(crate::HTML_TO_MARKDOWN_JS)
.unwrap()
.as_str()
.unwrap()
.to_string();
assert!(md.contains("# Title"), "missing H1: {}", md);
assert!(md.contains("## Sub"), "missing H2: {}", md);
assert!(md.contains("Body"), "missing paragraph text: {}", md);
}
#[test]
fn test_html_to_markdown_links_and_inline() {
let mut rt = setup_runtime(
r#"<html><body><p>Hello <strong>world</strong> <a href="https://x.test/">link</a> <em>em</em></p></body></html>"#,
);
let md = rt
.evaluate(crate::HTML_TO_MARKDOWN_JS)
.unwrap()
.as_str()
.unwrap()
.to_string();
assert!(md.contains("**world**"), "missing strong: {}", md);
assert!(md.contains("*em*"), "missing em: {}", md);
assert!(
md.contains("[link](https://x.test/)"),
"missing link: {}",
md
);
}
#[test]
fn test_html_to_markdown_lists() {
let mut rt = setup_runtime(
"<html><body><ul><li>A</li><li>B</li></ul><ol><li>X</li><li>Y</li></ol></body></html>",
);
let md = rt
.evaluate(crate::HTML_TO_MARKDOWN_JS)
.unwrap()
.as_str()
.unwrap()
.to_string();
assert!(md.contains("- A"), "missing unordered A: {}", md);
assert!(md.contains("- B"), "missing unordered B: {}", md);
assert!(md.contains("1. X"), "missing ordered X: {}", md);
}
#[test]
fn test_html_to_markdown_skips_script_and_style() {
let mut rt = setup_runtime(
"<html><body><p>Text</p><script>alert(1)</script><style>body{color:red}</style></body></html>",
);
let md = rt
.evaluate(crate::HTML_TO_MARKDOWN_JS)
.unwrap()
.as_str()
.unwrap()
.to_string();
assert!(md.contains("Text"), "missing visible text: {}", md);
assert!(!md.contains("alert"), "leaked script content: {}", md);
assert!(!md.contains("color:red"), "leaked style content: {}", md);
}
#[test]
fn test_page_content_puppeteer_pattern() {
let mut rt = setup_runtime("<!DOCTYPE html><html><head></head><body><p>Test</p></body></html>");
let result = rt.evaluate(
"(function() { let retVal = ''; if (document.doctype) retVal = new XMLSerializer().serializeToString(document.doctype); if (document.documentElement) retVal += document.documentElement.outerHTML; return retVal; })()"
).unwrap();
let html = result.as_str().unwrap();
assert!(html.starts_with("<!DOCTYPE html>"));
assert!(html.contains("<html>"));
assert!(html.contains("<p>Test</p>"));
}
#[test]
fn test_element_from_point_is_function() {
let mut rt = setup_runtime("<html><body></body></html>");
let kind = rt.evaluate("typeof document.elementFromPoint").unwrap();
assert_eq!(kind, serde_json::json!("function"));
let kind2 = rt.evaluate("typeof document.elementsFromPoint").unwrap();
assert_eq!(kind2, serde_json::json!("function"));
}
#[test]
fn test_element_from_point_in_viewport_returns_body() {
let mut rt = setup_runtime("<html><body><h1>Hi</h1></body></html>");
let tag = rt.evaluate("document.elementFromPoint(10, 10)?.tagName").unwrap();
assert_eq!(tag, serde_json::json!("BODY"));
}
#[test]
fn test_element_from_point_out_of_viewport_returns_null() {
let mut rt = setup_runtime("<html><body></body></html>");
let neg_x = rt.evaluate("document.elementFromPoint(-1, 10)").unwrap();
assert_eq!(neg_x, serde_json::Value::Null);
let neg_y = rt.evaluate("document.elementFromPoint(10, -1)").unwrap();
assert_eq!(neg_y, serde_json::Value::Null);
let huge = rt.evaluate("document.elementFromPoint(99999, 99999)").unwrap();
assert_eq!(huge, serde_json::Value::Null);
}
#[test]
fn test_elements_from_point_returns_array() {
let mut rt = setup_runtime("<html><body></body></html>");
let len_in = rt.evaluate("document.elementsFromPoint(10, 10).length").unwrap();
assert_eq!(len_in.as_f64().unwrap() as i64, 1);
let len_out = rt.evaluate("document.elementsFromPoint(-1, -1).length").unwrap();
assert_eq!(len_out.as_f64().unwrap() as i64, 0);
}
#[test]
fn test_element_from_point_non_numeric_returns_null() {
let mut rt = setup_runtime("<html><body></body></html>");
let nan = rt.evaluate("document.elementFromPoint(NaN, 10)").unwrap();
assert_eq!(nan, serde_json::Value::Null);
let inf = rt.evaluate("document.elementFromPoint(Infinity, 10)").unwrap();
assert_eq!(inf, serde_json::Value::Null);
}
// Issue #139 — proxy_url must thread through to both the ES-module
// loader (module_loader.rs) and op_fetch_url's reqwest client
// (ops.rs::build_request_client). Pre-fix both built clients with
// `Client::builder().build()` — no proxy — so JS fetch/XHR and
// dynamic imports silently bypassed BrowserContext.proxy_url.
//
// Phase 5.5 RED check: each test references a symbol that does NOT
// exist on main (proxy_url() accessor, with_proxy ctor,
// with_base_url_and_proxy ctor), so the tests fail to compile without
// the prod fix.
#[test]
fn http_client_round_trips_proxy_url() {
use obscura_net::{CookieJar, ObscuraHttpClient};
let jar = std::sync::Arc::new(CookieJar::new());
let configured =
ObscuraHttpClient::with_options(jar.clone(), Some("http://proxy.test:8080"));
assert_eq!(
configured.proxy_url(),
Some("http://proxy.test:8080"),
"proxy_url() must expose the value passed to with_options"
);
let direct = ObscuraHttpClient::with_options(jar, None);
assert_eq!(
direct.proxy_url(),
None,
"proxy_url() must return None when no proxy was configured"
);
}
#[test]
fn module_loader_stores_proxy_for_dynamic_imports() {
use crate::module_loader::ObscuraModuleLoader;
let loader = ObscuraModuleLoader::with_proxy(
"https://example.com/",
Some("http://proxy.test:8080".to_string()),
);
assert_eq!(loader.proxy_url.as_deref(), Some("http://proxy.test:8080"));
assert_eq!(loader.base_url, "https://example.com/");
// Default constructor must keep the historical "no proxy" behaviour.
let direct = ObscuraModuleLoader::new("https://example.com/");
assert_eq!(direct.proxy_url, None);
}
#[test]
fn runtime_with_base_url_and_proxy_constructs_successfully() {
// Sanity-check the public ctor that page.rs uses to thread proxy
// through to the module loader. Direct (None) and proxied paths
// must both initialise the JS environment.
let _direct = ObscuraJsRuntime::with_base_url_and_proxy("https://example.com/", None);
let _proxied = ObscuraJsRuntime::with_base_url_and_proxy(
"https://example.com/",
Some("http://proxy.test:8080".to_string()),
);
}
// ── Issue #45 (Playwright actionability) regression tests ────────────────
// Kept at the end of the module so they don't share textual context with
// unrelated test additions in other branches (avoids spurious merge
// conflicts when both this branch and an unrelated bootstrap.js change
// add tests near the start of `mod tests`).
/// Playwright >= 1.25 calls `element.checkVisibility(...)` before every
/// input event. If the method isn't defined Playwright retries until its
/// action timeout fires. Without a layout engine we can't compute it
/// properly, so the stub always returns true — still strictly better
/// than the undefined path.
#[test]
fn element_check_visibility_is_callable() {
let mut rt = setup_runtime(r#"<div id="x">x</div>"#);
let result = rt
.evaluate("document.getElementById('x').checkVisibility({checkOpacity: true})")
.unwrap();
assert_eq!(result, serde_json::json!(true));
let typeof_method = rt
.evaluate("typeof document.getElementById('x').checkVisibility")
.unwrap();
assert_eq!(typeof_method, serde_json::json!("function"));
}
/// Playwright's `getByRole` / `getByLabel` locators resolve via ARIA
/// reflection properties. Without the getters those locators always
/// fail. Reflect the underlying aria-* attributes.
#[test]
fn element_aria_reflection_properties_read_aria_attrs() {
let mut rt = setup_runtime(
r#"<button id="b" role="tab" aria-label="Settings" aria-selected="true">x</button>"#,
);
let result = rt
.evaluate(
r#"
const el = document.getElementById('b');
return [el.role, el.ariaLabel, el.ariaSelected];
"#,
)
.unwrap();
assert_eq!(result, serde_json::json!(["tab", "Settings", "true"]));
}
/// Setting an ARIA reflection property must write through to the
/// underlying attribute so frameworks that toggle state via
/// `el.ariaExpanded = 'true'` actually update the DOM.
/// Regression: React 18 / mobile SPAs (e.g. goofish.com) call
/// addEventListener on navigator.connection (NetworkInformation) and
/// navigator.serviceWorker (ServiceWorkerContainer). Both are EventTargets
/// in real browsers; missing the method crashed the app bundle with
/// "addEventListener is not a function".
#[test]
fn navigator_eventtarget_stubs_expose_add_event_listener() {
let mut rt = setup_runtime("<div></div>");
let result = rt
.evaluate(
r#"
return [
typeof navigator.connection.addEventListener,
typeof navigator.serviceWorker.addEventListener,
];
"#,
)
.unwrap();
assert_eq!(result, serde_json::json!(["function", "function"]));
}
/// Regression test for #285: DDoS-Guard's challenge calls
/// `t.insertAdjacentText(...)` and dies with `TypeError: ... is not a
/// function` because `Element.prototype.insertAdjacentText` was missing.
/// Verify all four positions place a Text node (NOT parsed HTML) at the
/// right spot. Tests `insertAdjacentText` exists, is callable, and that
/// inserted content remains literal text — angle brackets must not be
/// parsed as markup, which is the whole point of the API.
#[test]
fn element_insert_adjacent_text_polyfill() {
let mut rt = setup_runtime(r#"<div id="p"><span id="t">X</span></div>"#);
let result = rt
.evaluate(
r#"
const t = document.getElementById('t');
t.insertAdjacentText('afterbegin', 'AB');
t.insertAdjacentText('beforeend', 'BE');
t.insertAdjacentText('beforebegin', 'BB');
t.insertAdjacentText('afterend', 'AE');
t.insertAdjacentText('beforeend', '<b>raw</b>');
return [
typeof Element.prototype.insertAdjacentText,
document.getElementById('p').textContent,
t.getElementsByTagName('b').length,
];
"#,
)
.unwrap();
assert_eq!(
result,
serde_json::json!(["function", "BBABXBE<b>raw</b>AE", 0])
);
}
/// Regression test for #285: `Element.prototype.insertAdjacentElement`
/// was missing alongside `insertAdjacentText`. Verify all four positions
/// place the given element correctly and that the inserted element is
/// returned (per spec — that's the contract callers rely on for chaining).
#[test]
fn element_insert_adjacent_element_polyfill() {
let mut rt = setup_runtime(r#"<div id="p"><span id="t">X</span></div>"#);
let result = rt
.evaluate(
r#"
const t = document.getElementById('t');
const before = document.createElement('b'); before.id = 'before';
const after = document.createElement('i'); after.id = 'after';
const inside = document.createElement('em'); inside.id = 'inside';
const last = document.createElement('u'); last.id = 'last';
const r1 = t.insertAdjacentElement('beforebegin', before);
const r2 = t.insertAdjacentElement('afterend', after);
const r3 = t.insertAdjacentElement('afterbegin', inside);
const r4 = t.insertAdjacentElement('beforeend', last);
const siblings = Array.from(document.getElementById('p').children).map(c => c.id);
const inT = Array.from(t.children).map(c => c.id);
return [
typeof Element.prototype.insertAdjacentElement,
r1 === before && r2 === after && r3 === inside && r4 === last,
siblings,
inT,
];
"#,
)
.unwrap();
assert_eq!(
result,
serde_json::json!([
"function",
true,
["before", "t", "after"],
["inside", "last"]
])
);
}
#[test]
fn console_log_error_does_not_trigger_prepare_stack_trace() {
let mut rt = setup_runtime("<div></div>");
let result = rt.evaluate(r#"
let called = false;
const saved = Error.prepareStackTrace;
Error.prepareStackTrace = function() { called = true; return saved; };
const e = new Error("test");
console.log(e);
Error.prepareStackTrace = saved;
return called;
"#).unwrap();
assert_eq!(result, serde_json::json!(false));
}
#[test]
fn element_aria_reflection_setters_write_through() {
let mut rt = setup_runtime(r#"<div id="d"></div>"#);
let result = rt
.evaluate(
r#"
const el = document.getElementById('d');
el.role = 'menu';
el.ariaExpanded = 'true';
return [el.getAttribute('role'), el.getAttribute('aria-expanded')];
"#,
)
.unwrap();
assert_eq!(result, serde_json::json!(["menu", "true"]));
}
}