Add EventTarget methods to navigator.connection and serviceWorker

NetworkInformation (navigator.connection) and ServiceWorkerContainer (navigator.serviceWorker) are EventTargets in real browsers. React 18 and mobile SPAs call addEventListener on them; the stubs lacked it, so the app bundle crashed with 'addEventListener is not a function' (e.g. goofish.com).
This commit is contained in:
SGavrl committed 2026-06-10 19:47:23 +00:00
1 parent ee86dbf996
commit 534de77882
2 files changed
+23 -2

No files matched your search

+2 -2
View File
@@ -2469,7 +2469,7 @@ globalThis.navigator = {
vendor: "Google Inc.", product: "Gecko", productSub: "20030107",
doNotTrack: null,
deviceMemory: 8,
connection: { effectiveType: "4g", rtt: 50, downlink: 10, saveData: false },
connection: { effectiveType: "4g", rtt: 50, downlink: 10, saveData: false, onchange: null, addEventListener(){}, removeEventListener(){}, dispatchEvent(){return true;} },
get webdriver() { return false; },
pdfViewerEnabled: true,
get plugins() {
@@ -2518,7 +2518,7 @@ globalThis.navigator = {
},
toJSON() { return {brands:this.brands,mobile:this.mobile,platform:this.platform}; },
},
serviceWorker: { ready: Promise.resolve(), register(){return Promise.resolve();}, getRegistrations(){return Promise.resolve([]);}, controller: null },
serviceWorker: { ready: Promise.resolve(), register(){return Promise.resolve();}, getRegistrations(){return Promise.resolve([]);}, controller: null, oncontrollerchange: null, onmessage: null, addEventListener(){}, removeEventListener(){}, dispatchEvent(){return true;} },
mediaDevices: {
enumerateDevices() {
return Promise.resolve([
+21
View File
@@ -2357,6 +2357,27 @@ mod tests {
/// Setting an ARIA reflection property must write through to the
/// underlying attribute so frameworks that toggle state via
/// `el.ariaExpanded = 'true'` actually update the DOM.
/// Regression: React 18 / mobile SPAs (e.g. goofish.com) call
/// addEventListener on navigator.connection (NetworkInformation) and
/// navigator.serviceWorker (ServiceWorkerContainer). Both are EventTargets
/// in real browsers; missing the method crashed the app bundle with
/// "addEventListener is not a function".
#[test]
fn navigator_eventtarget_stubs_expose_add_event_listener() {
let mut rt = setup_runtime("<div></div>");
let result = rt
.evaluate(
r#"
return [
typeof navigator.connection.addEventListener,
typeof navigator.serviceWorker.addEventListener,
];
"#,
)
.unwrap();
assert_eq!(result, serde_json::json!(["function", "function"]));
}
/// Regression test for #285: DDoS-Guard's challenge calls
/// `t.insertAdjacentText(...)` and dies with `TypeError: ... is not a
/// function` because `Element.prototype.insertAdjacentText` was missing.